Msalem/fix scheduler button #570
Conversation
There was a problem hiding this comment.
@msalemcode I turned on the metered scheduler, created an item and turned off. But looks like my meters are still being reported. I think this might a major functionality gap. hence assigning the PR back to you. Please let me know if you want to discuss further.
There was a problem hiding this comment.
@msalemcode I turned on the metered scheduler, created an item and turned off. But looks like my meters are still being reported. I think this might a major functionality gap. hence assigning the PR back to you. Please let me know if you want to discuss further.
There was a problem hiding this comment.
Changes observed:
- doc updates with new way of enabling meter scheduler using db setting
- added appconfigservice into the base controller and set the logic to enable/disable meter scheduler
- passed the appconfig service from all controllers
- adjusted to show/hide scheduler controller actions based on 2 and other views
- baseline 741 seed/dessed added for new db setting
- meter scheduler logic updated based on the dbsetting
- Tested directed deploy and upgrade scenario,
@msalemcode all looks good except for one step. Lets say 7.4.0 is in use with active scheduler items and someone upgraded to this release and the db setting is by default disabled, which means all the existing scheduler items wont run right. We should go in manually and update the db setting. How should we handle this?
8.
9.
10.
|
Added installer message that the scheduler is enabled on upgrade if the version upgrade is > 7.4.0 |
There was a problem hiding this comment.
@msalemcode could you validate the below scenario please?
- deploy 7.4.0
- create hourly schedule
- let it run once
- upgrade to your new PR code
- Expected, hourly job should run by default
- Actual: Item didnt get picked up
Enforce the scheduler code to check if the feature is enabled.
Test the PR:
1- Enable the metered support flag. Make sure you can access all pages for scheduler including the link from Subscription Managed Usage
2- Disable the metered support flag. Make sure you can not see or access the any scheduler page
3- try hardcoded url <>/scheduler <>/scheduler/NewScheduler ..etc
4- Enable again and see if you can access the pages
Any other use case please let me know.