-
Notifications
You must be signed in to change notification settings - Fork 555
feat: adding switch for internet fallback on Private DNS zones #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @picccard! Let me know when you're ready for review and can get this merged in. |
@oZakari this is ready for review now. Test complete and screenshot added. This could be fixed by splitting the bicep module OR the AVD module should ignore the |
Thanks for letting me know @picccard. Will leave a notice in the release notes for this and we can make changes on the AVM side if we get enough customers running into issues. |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Code looks good for this one from first glance, just need to sort out why the tests are failing in the backend. I think it's related to a security update with checking out forks, but should be able to merge this in shortly. |
Will this also be enabled for Azure VWAN network deployment, if the option 'parVirtualNetworkResourceIdsToLinkTo' is specified in the 'vwanConnectivity.parameters.all.json' parameter file? |
Overview/Summary
At the start of 2025 there was added the option to enable "Fallback to internet" for private DNS zones for Private Link resources.
This PR allows this option to be set for all private DNS zones.
Related Issues/Work Items
This PR fixes/adds/changes/removes
Breaking Changes
Default will not change.
parPrivateDnsZones
to deploy any any non-privatelink-zone (e.g. contoso.internal), vnet links for these zones will fail, becauseresolutionPolicy
is only allowed on privatelink-zones.Here is an example:
Testing Evidence
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch