Skip to content

Conversation

picccard
Copy link
Contributor

@picccard picccard commented May 28, 2025

Overview/Summary

At the start of 2025 there was added the option to enable "Fallback to internet" for private DNS zones for Private Link resources.
This PR allows this option to be set for all private DNS zones.

Related Issues/Work Items

This PR fixes/adds/changes/removes

  1. Allows consumers to enable "Fallback to internet" on privatelink-dns-zones.

image

Breaking Changes

Default will not change.

⚠️ However if consumers use the parameter parPrivateDnsZones to deploy any any non-privatelink-zone (e.g. contoso.internal), vnet links for these zones will fail, because resolutionPolicy is only allowed on privatelink-zones.

Here is an example:

parPrivateDnsZones: [
  'privatelink.postgres.database.azure.com'
  'privatelink.mysql.database.azure.com'
  'contoso.internal'
]

image

Testing Evidence

image

As part of this Pull Request I have

@picccard picccard had a problem deploying to BicepUpdateDocumentation May 28, 2025 08:14 — with GitHub Actions Failure
@picccard picccard changed the title Add switch for internet fallback on Private DNS zones feat: Add switch for internet fallback on Private DNS zones May 30, 2025
@picccard picccard had a problem deploying to BicepUpdateDocumentation May 30, 2025 21:21 — with GitHub Actions Failure
@oZakari
Copy link
Contributor

oZakari commented Jun 2, 2025

Thanks @picccard! Let me know when you're ready for review and can get this merged in.

@oZakari oZakari added Area: Networking 🌐 Issues / PR's related to Networking Type: Feature Request ➕ New feature or request labels Jun 2, 2025
@picccard picccard had a problem deploying to BicepUpdateDocumentation June 15, 2025 15:06 — with GitHub Actions Failure
@picccard picccard had a problem deploying to BicepUpdateDocumentation June 15, 2025 15:14 — with GitHub Actions Failure
@picccard picccard marked this pull request as ready for review June 15, 2025 15:14
@picccard
Copy link
Contributor Author

picccard commented Jun 15, 2025

@oZakari this is ready for review now. Test complete and screenshot added.

⚠️ See breaking changes, the default ALZ implementation is fine, but there could be edge cases where consumers use their own private-dns-zones → leading to deployment failure

This could be fixed by splitting the bicep module modPrivateDnsZonesAVM into two modules, one module for parPrivateDnsZones filter zone-name contains 'privatelink', and one for zone-name not-contains 'privatelink'.

OR the AVD module should ignore the resolutionPolicy property for non-privatelink-zones, as its known that will throw errors during deployment...

@picccard picccard had a problem deploying to BicepUpdateDocumentation June 15, 2025 15:20 — with GitHub Actions Failure
@picccard picccard had a problem deploying to BicepUpdateDocumentation June 15, 2025 15:39 — with GitHub Actions Failure
@picccard picccard changed the title feat: Add switch for internet fallback on Private DNS zones feat: adding switch for internet fallback on Private DNS zones Jun 15, 2025
@picccard picccard had a problem deploying to BicepUpdateDocumentation June 15, 2025 15:40 — with GitHub Actions Failure
@picccard picccard had a problem deploying to BicepUpdateDocumentation June 15, 2025 15:45 — with GitHub Actions Failure
@picccard picccard had a problem deploying to BicepUpdateDocumentation June 20, 2025 09:20 — with GitHub Actions Failure
@oZakari
Copy link
Contributor

oZakari commented Jun 23, 2025

Thanks for letting me know @picccard. Will leave a notice in the release notes for this and we can make changes on the AVM side if we get enough customers running into issues.

@oZakari oZakari had a problem deploying to BicepUpdateDocumentation June 23, 2025 03:09 — with GitHub Actions Failure
@oZakari
Copy link
Contributor

oZakari commented Jun 23, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari had a problem deploying to BicepUpdateDocumentation June 26, 2025 04:12 — with GitHub Actions Failure
@oZakari
Copy link
Contributor

oZakari commented Jun 26, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari
Copy link
Contributor

oZakari commented Jun 26, 2025

Code looks good for this one from first glance, just need to sort out why the tests are failing in the backend. I think it's related to a security update with checking out forks, but should be able to merge this in shortly.

@KiZach
Copy link
Contributor

KiZach commented Jun 30, 2025

Will this also be enabled for Azure VWAN network deployment, if the option 'parVirtualNetworkResourceIdsToLinkTo' is specified in the 'vwanConnectivity.parameters.all.json' parameter file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Type: Feature Request ➕ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AMPLS into Landing Zone
3 participants