Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc fixes #32

Merged
merged 7 commits into from
Apr 5, 2024
Merged

fix: misc fixes #32

merged 7 commits into from
Apr 5, 2024

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Apr 4, 2024

Purpose

Fixes a few issues I found during testing

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@sinedied sinedied requested a review from glaucia86 April 4, 2024 18:55
@glaucia86 glaucia86 added the bug Something isn't working label Apr 5, 2024
glaucia86
glaucia86 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaucia86 glaucia86 merged commit 7f22e9f into main Apr 5, 2024
7 checks passed
@glaucia86 glaucia86 deleted the fixes branch April 5, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees

@sinedied sinedied

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinedied @glaucia86