Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve prompts and misc fixes #29

Merged
merged 11 commits into from
Apr 4, 2024
Merged

feat: improve prompts and misc fixes #29

merged 11 commits into from
Apr 4, 2024

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Apr 4, 2024

Purpose

  • Add full system prompts
  • Add script to upload pdf when working locally
  • Fix blob uploading

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

sinedied
sinedied commented Apr 4, 2024
View reviewed changes
packages/api/src/functions/documents-post.ts
const dimensions = 1536;
const similarity = AzureCosmosDBSimilarityType.COS;
await store.createIndex(numberLists, dimensions, similarity);
await store.createIndex();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that these were the default param, so the less code the better :)

@sinedied sinedied requested a review from glaucia86 April 4, 2024 16:48
@glaucia86 glaucia86 added bug Something isn't working backend labels Apr 4, 2024
glaucia86
glaucia86 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaucia86 glaucia86 merged commit b937b79 into main Apr 4, 2024
5 checks passed
@glaucia86 glaucia86 deleted the prompts branch April 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees

@sinedied sinedied

Labels
backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinedied @glaucia86