Bug fixes for migrate-javaee-app-to-azure-training #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andxu
commented
Jul 8, 2021
•
andxu
commented
- Fix the compile error on java 11
- Fix the wrong pricing tier P1v2 in readme(the value in pom.xml is right)
- Fix the runtime jboss 7.2 since portal has replace jboss 7.2 with jboss 7
selvasingh
reviewed
Jul 8, 2021
| @@ -52,7 +52,7 @@ public static String display(Object object) | |||
| // Find a matching getter and invoke it to display the key | |||
| for (Method method : object.getClass().getDeclaredMethods()) | |||
| { | |||
| if (method.equals(new PropertyDescriptor(field.getName(), object.getClass()).getReadMethod())) | |||
There was a problem hiding this comment.
@andxu - we should not change this line. The scenario is all about migrating an existing Java EE app to Azure. If you must change this, then we should contribute to the upstream repo owned by Antonio and then we should absorb it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.