Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change private registry to false so it works with GitHub/Container Apps Tutorial #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanWahlin
Copy link

Purpose

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

Updates a single line in deploy/main.bicep. Currently the GitHub tutorial at https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash uses this repo to demonstrate GitHub Actions and Azure Container Apps. However, the deploy/main.bicep marks the GitHub registry for the package as true but it looks like that should be false.

This PR changes isPrivateRegistry to false in deploy/main.bicep.

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

What to Check

@DanWahlin DanWahlin changed the title Change private registry to false Change private registry to false so it works with GitHub/Container Apps Tutorial Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant