Call Automation Media Streaming Sample #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninika
reviewed
Dec 20, 2022
| { | ||
| String logMessage; | ||
| logMessage = messageType + " " + message; | ||
| System.out.println(logMessage); |
Ninika
reviewed
Dec 20, 2022
|
|
||
| Logger.logMessage(Logger.MessageType.INFORMATION, "AnswerCallWithResponse -- > " + getResponse(response)); | ||
| Logger.logMessage(Logger.MessageType.INFORMATION, "Call Connection ID -- > " + answerCallResult.getCallConnectionProperties().getCallConnectionId()); | ||
|
|
Ninika
reviewed
Dec 20, 2022
| @PostMapping(value = "/OnIncomingCall", consumes = "application/json", produces = "application/json") | ||
| public ResponseEntity<?> OnIncomingCall(@RequestBody(required = false) String data){ | ||
| List<EventGridEvent> eventGridEvents = EventGridEvent.fromString(data); | ||
|
|
Ninika
reviewed
Dec 20, 2022
| List<EventGridEvent> eventGridEvents = EventGridEvent.fromString(data); | ||
|
|
||
| if(eventGridEvents.stream().count() > 0) | ||
| { |
There was a problem hiding this comment.
please indent the code.. keep the brackets at the right spacing
Ninika
reviewed
Dec 20, 2022
| EventGridEvent eventGridEvent = eventGridEvents.get(0); | ||
| BinaryData eventData = eventGridEvent.getData(); | ||
|
|
||
| if (eventGridEvent.getEventType().equals(SystemEventNames.EVENT_GRID_SUBSCRIPTION_VALIDATION)) |
There was a problem hiding this comment.
You can change it to SystemEventNames.EVENT_GRID_SUBSCRIPTION_VALIDATION.equals(eventGridEvent.getEventType()) to avoid null pointers.
Also check if eventGridEvent could be null
Ninika
reviewed
Dec 20, 2022
| SubscriptionValidationEventData subscriptionValidationEvent = eventData.toObject(SubscriptionValidationEventData.class); | ||
| SubscriptionValidationResponse responseData = new SubscriptionValidationResponse(); | ||
| responseData.setValidationResponse(subscriptionValidationEvent.getValidationCode()); | ||
|
|
Ninika
reviewed
Dec 20, 2022
| return new ResponseEntity<>(e.getMessage(), HttpStatus.INTERNAL_SERVER_ERROR); | ||
| } | ||
| } | ||
| else if(eventGridEvent.getEventType().equals("Microsoft.Communication.IncomingCall")){ |
Ninika
reviewed
Dec 20, 2022
| } | ||
| } | ||
| catch(Exception e){ | ||
| e.printStackTrace(); |
Ninika
suggested changes
Dec 20, 2022
Ninika
left a comment
Ninika
left a comment
There was a problem hiding this comment.
Please incorporate the requested comments
…TION.equals(eventGridEvent.getEventType()) && eventGridEvent!=null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information