-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ultrahonk finally #100
ultrahonk finally #100
Conversation
cc @olehmisar thanks for all your work with the hardhat plugin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we note the tradeoffs between ultraplonk and ultrahonk in the README? Or are we planning to drop UP altogether so should just forget about it? |
We're looking into dropping UP but let's see, depends if we're gonna optimize UH verifier contract or not... still up for debate I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to make it more obvious that UH on-chain verification isn't working, but otherwise looks good!
Re UltraPlonk and UltraHonk:
|
This PR resolves #97 |
Makes sense, thanks @Savio-Sou. We were discussing also switching back to UP because the UH verifier is broken, so we could have a fully functioning example. What do you think, should we merge it with UH, make a note that the UH verifier is being worked on and will be updated soon? |
Merging with UH + note sounds reasonable. Which / Do we have an Issue for UH's broken verifier? We should prioritize fixing it asap in parallel. |
Just because I was already working on it, I'm pushing a refactor that allows for both UltraPlonk and UltraHonk. It also tests both, but skips the verifier contract for UltraHonk. |
We don't, I have a pretty good idea of what could be missing so I'm looking into it so I can provide more context to the team |
This is a working version for Noir 1.0.0-beta.0 using Barretenberg v0.63.0
Uses ultrahonk which is currently slightly broken on the verifier contract generation on the bb side. Commenting out the test until we figure this out (interface won't change)