Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/plugin_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,14 @@ on:
permissions:
contents: write

env:
GO_VERSION: 1.26.2

jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: pipe-cd/pipecd
fetch-depth: 0
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/stale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,4 @@ jobs:
close-pr-message: 'This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.'
days-before-pr-stale: 30
days-before-pr-close: 7
delete-branch: true
exempt-pr-labels: 'not-auto-close'
exempt-pr-labels: 'not-auto-close'
13 changes: 4 additions & 9 deletions .github/workflows/thank-you.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ permissions:

jobs:
thank-you:
# Only run if the PR was actually merged
if: github.event.pull_request.merged
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
# We must check out the code to read the MAINTAINERS.json file
- name: Checkout repository
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.base.sha }}

- name: Leave a Thank You Comment
uses: actions/github-script@v7
Expand All @@ -26,29 +26,24 @@ jobs:
const fs = require('fs');
const creator = context.payload.pull_request.user.login;

// Skip bots to avoid comment loops
if (creator.endsWith('[bot]')) {
console.log('Skipping bot account.');
return;
}

// Read maintainers list from JSON file
const maintainersData = JSON.parse(fs.readFileSync('MAINTAINERS.json', 'utf8'));
const maintainers = maintainersData.maintainers.map(m => m.toLowerCase());

// Skip core maintainers to avoid spamming the team
if (maintainers.includes(creator.toLowerCase())) {
console.log(`Skipping maintainer account: ${creator}`);
return;
}

const message = 'Thank you for contributing to PipeCD! The changes in this pull request will be part of the upcoming release!';
const message = `Thank you for contributing to PipeCD, @${creator}! The changes in this pull request will be part of the upcoming release!`;

// Post the comment to the PR
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.payload.pull_request.number,
body: message
});

2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Documentation
# Documentation XYZ CHANGE FOR TESTING

The source files for the documentation is placing in [content](https://github.com/pipe-cd/pipecd/tree/master/docs/content) directory.

Expand Down
20 changes: 20 additions & 0 deletions workflow-audit/issues/bug-plugin-release-go-version-undefined.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Bug: plugin_release.yaml references undefined GO_VERSION and uses non-existent checkout@v5

**File:** `.github/workflows/plugin_release.yaml`

## Problem

Two defects that will cause this workflow to fail on every plugin release:

1. `setup-go` references `${{ env.GO_VERSION }}` but `GO_VERSION` is never declared in this workflow's `env:` block. It expands to an empty string, causing `setup-go` to pick an arbitrary default Go version rather than the project-required `1.26.2`.

2. `actions/checkout@v5` is used on line 21. v5 does not exist — all other workflows in this repo use the SHA-pinned `actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2`.

## Fix

- Add `GO_VERSION: 1.26.2` to the workflow `env:` block.
- Change `actions/checkout@v5` to `actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2`.

## Impact

Every manual plugin release silently uses the wrong Go version or fails checkout entirely.