refactor: remove duplicate utility logic (issue #317) - #327
Merged
Conversation
Removes duplicate delay() in httpInterceptor.ts and sleep() in rpcEndpointManager.ts. Both were identical: `new Promise(resolve => setTimeout(resolve, ms))`. Now centralized in src/utils/sleep.ts and imported by both callers. Adds regression test in tests/sleep.test.ts and docs/utility-ownership.md explaining placement rules. Closes #317
Contributor
| \nGitHub has not finished calculating whether this PR can be merged cleanly.\n\nThe auto-merge automation will skip this PR for now. Re-run the automation later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was duplicated
delay()insrc/utils/httpInterceptor.tsandsleep()insrc/network/rpcEndpointManager.tswere identical implementations:new Promise(resolve => setTimeout(resolve, ms)).What was centralized
src/utils/sleep.tswith the singlesleep()helpersrc/utils/httpInterceptor.tsto importsleepinstead of defining localdelay()src/network/rpcEndpointManager.tsto importsleepinstead of defining localsleep()src/utils/index.tsexport for the new utilityTests
tests/sleep.test.ts(4 test cases covering timing, undefined return, zero delay, promise type)Documentation
docs/utility-ownership.mdexplaining where shared utilities belong and how to avoid re-introducing duplicatesCloses #317