Skip to content

Adds a read the docs config file #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

alexhroom
Copy link
Contributor

@alexhroom alexhroom commented May 11, 2023

Fixes issues caused by readthedocs/readthedocs.org#10290. originally part of #1419.

@alexhroom
Copy link
Contributor Author

how weird. a few issues: on the CI,

 ERROR: test_normalized_parameters (axelrod.tests.strategies.test_cycler.TestEvolvableCycler)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\Axelrod\Axelrod\axelrod\tests\strategies\test_cycler.py", line 177, in test_normalized_parameters
    self.player_class(cycle=cycle, seed=1)._normalize_parameters(
  File "D:\a\Axelrod\Axelrod\axelrod\player.py", line 65, in __call__
    obj = type.__call__(cls, *args, **kwargs)
  File "D:\a\Axelrod\Axelrod\axelrod\strategies\cycler.py", line 119, in __init__
    cycle, cycle_length = self._normalize_parameters(cycle, cycle_length)
  File "D:\a\Axelrod\Axelrod\axelrod\strategies\cycler.py", line 132, in _normalize_parameters
    raise InsufficientParametersError(
axelrod.evolvable_player.InsufficientParametersError: Insufficient Parameters to instantiate EvolvableCycler

despite this PR not changing anything in the actual code base.

also, the read the docs build failing despite me literally copying the files exactly from the successful #1419 setup

@drvinceknight
Copy link
Member

also, the read the docs build failing despite me literally copying the files exactly from the successful #1419 setup

Here's the failure traceback on rtd:

$ python -m pip install --exists-action=w --no-cache-dir -r docs/requirements.txt
Collecting docutils<=0.17 (from -r docs/requirements.txt (line 1))
  Downloading docutils-0.17-py2.py3-none-any.whl (575 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 575.1/575.1 kB 93.6 MB/s eta 0:00:00
ERROR: Ignored the following versions that require a different python version: 1.22.0 Requires-Python >=3.8; 1.22.1 Requires-Python >=3.8; 1.22.2 Requires-Python >=3.8; 1.22.3 Requires-Python >=3.8; 1.22.4 Requires-Python >=3.8; 1.23.0 Requires-Python >=3.8; 1.23.0rc1 Requires-Python >=3.8; 1.23.0rc2 Requires-Python >=3.8; 1.23.0rc3 Requires-Python >=3.8; 1.23.1 Requires-Python >=3.8; 1.23.2 Requires-Python >=3.8; 1.23.3 Requires-Python >=3.8; 1.23.4 Requires-Python >=3.8; 1.23.5 Requires-Python >=3.8; 1.24.0 Requires-Python >=3.8; 1.24.0rc1 Requires-Python >=3.8; 1.24.0rc2 Requires-Python >=3.8; 1.24.1 Requires-Python >=3.8; 1.24.2 Requires-Python >=3.8; 1.24.3 Requires-Python >=3.8
ERROR: Could not find a version that satisfies the requirement numpy==1.24.3 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 1.13.3, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5, 1.21.6)
ERROR: No matching distribution found for numpy==1.24.3

@alexhroom
Copy link
Contributor Author

my bad - i mistakenly put the yaml in the docs/ directory rather than the root directory.

@marcharper
Copy link
Member

LGTM

@drvinceknight drvinceknight merged commit 16048c1 into Axelrod-Python:dev May 17, 2023
drvinceknight pushed a commit that referenced this pull request Jun 9, 2023
* added attributes to mock player

* fixed mock player addition

* added test for size checking

* added actions_size to Classifier

* added actions_size to tutorial

* re-added the actual implementation (git shenanigans)

* fixed typo

* fixed docstring

* changed size checking to a general assumptions model

* fixed some bugs

* added some tests

* added user option for strictness of assumption checking

* fixed tests

* updated docs

* added assumptions_satisfy helper method

* removed unnecessary if statement

* Revert "removed unnecessary if statement"

This reverts commit c4359bc.

* added test for assumptions_satisfy

* changed attributes -> characteristics

* more attributes -> characteristics

* changed name to game_characteristics when not directly referencing a Game

* Adds a read the docs config file (#1423)

* added a read the docs config file

* moved yaml to root directory

* removed default characteristic

* made mock player safer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants