docs: fix CONTRIBUTING claims and add the missing CODE_OF_CONDUCT - #34
Conversation
…-479/480/481) - Drop python-dotenv from the install line (the bots use their own loader). - CI targets Python 3.14, not 3.12. - Add CODE_OF_CONDUCT.md, which CONTRIBUTING already linked but did not exist.
Avicennasis
left a comment
There was a problem hiding this comment.
The two stated corrections are accurate and the Code of Conduct link resolves, but the documented setup still fails in a fresh virtualenv: it runs pre-commit install without installing pre-commit. Add pre-commit to the install command (preferably pin all dev tools through a requirements/pyproject file rather than a floating manual list).
Also, python-dotenv remains installed by .github/workflows/test.yml even though the PR correctly identifies it as a phantom dependency. Remove it there too or avoid claiming the dependency has been removed from the project setup. All current GitHub checks and git diff --check are green.
|
Re-review at 1fd8a84: added the missing |
Closes #48954, #48955, #48956. Removes the phantom
python-dotenvdependency, corrects the CI Python version (3.14, not 3.12), and adds theCODE_OF_CONDUCT.mdthat CONTRIBUTING already referenced.