Skip to content

docs: fix CONTRIBUTING claims and add the missing CODE_OF_CONDUCT - #34

Merged
Avicennasis merged 2 commits into
mainfrom
fix/fr-contributing-docs
Sep 15, 2026
Merged

Avicennasis merged 2 commits into
mainfrom
fix/fr-contributing-docs

Conversation

@Avicennasis

Copy link
Copy Markdown
Owner

Closes #48954, #48955, #48956. Removes the phantom python-dotenv dependency, corrects the CI Python version (3.14, not 3.12), and adds the CODE_OF_CONDUCT.md that CONTRIBUTING already referenced.

…-479/480/481)

- Drop python-dotenv from the install line (the bots use their own loader).
- CI targets Python 3.14, not 3.12.
- Add CODE_OF_CONDUCT.md, which CONTRIBUTING already linked but did not exist.

@Avicennasis Avicennasis left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two stated corrections are accurate and the Code of Conduct link resolves, but the documented setup still fails in a fresh virtualenv: it runs pre-commit install without installing pre-commit. Add pre-commit to the install command (preferably pin all dev tools through a requirements/pyproject file rather than a floating manual list).

Also, python-dotenv remains installed by .github/workflows/test.yml even though the PR correctly identifies it as a phantom dependency. Remove it there too or avoid claiming the dependency has been removed from the project setup. All current GitHub checks and git diff --check are green.

@Avicennasis

Copy link
Copy Markdown
Owner Author

Re-review at 1fd8a84: added the missing pre-commit install, pinned the documented Ruff version to the workflow/config 0.15.22, and removed the phantom python-dotenv CI install so docs and automation agree. Workflow YAML parses; Ruff check/format, 40 tests, and diff checks pass locally. Fresh full GitHub CI is running.

@Avicennasis
Avicennasis merged commit 566dfdd into main Sep 15, 2026
6 checks passed
@Avicennasis
Avicennasis deleted the fix/fr-contributing-docs branch September 15, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant