ci: scan application source with CodeQL, not just workflow YAML - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL was scanning
language: [actions]— GitHub Actions workflow YAML, and zero lines of this repository's own source.This was not neglect. Deploying the advanced CodeQL workflow requires disabling code-scanning default setup first (they are mutually exclusive), and that was done fleet-wide on 2026-06-11 per
operations/new-github-repo-setup.md. Default setup scans source — so the documented procedure traded real source coverage for actions-only coverage, and that consequence was never written down. Across the 19 repos carryingcodeql.yml, 17 were in this state.The cost was not hypothetical:
eldritch-codexhad an openjs/prototype-pollution-utilityalert that went unscanned for ~4 months (fixed in Avicennasis/eldritch-codex#25), andAvicBotChatcarries two high-severitypy/clear-text-logging-sensitive-dataalerts on the same file, one of which recurred two months after the first was fixed — exactly what continuous scanning exists to catch.Change
Adds this repo's actual source language(s) to the matrix.
actionsis kept as the floor.The job name is pinned to
Analyze (${{ matrix.language }})on purpose: GitHub derives an unnamed matrix job's title from all its matrix keys, so adding one later renames the job. Where a branch ruleset requiresAnalyze (actions), that makes the rule unsatisfiable rather than failing — PRs sit BLOCKED with every check green, and only the merge attempt names the missing context. Cost real time on simsys-logevent#46 and simsys-metrics#83.Action SHAs are reused verbatim from this repo's existing workflow — none invented.
Upstream fix so this does not regrow: Avicennasis/ClaudeCode#225 makes the
/git-standardstemplate language-aware (itspolicy: replacewould otherwise revert this on the next run), plus the wiki section that documents the trade.Verify by check-run NAME, not just that CodeQL went green — a green
Analyze (actions)alone would mean this did not land.