fix(azure-aks-multicluster): stop managing global DCF enable, document as prereq - #80
Open
cmchenr wants to merge 1 commit into
Open
fix(azure-aks-multicluster): stop managing global DCF enable, document as prereq#80cmchenr wants to merge 1 commit into
cmchenr wants to merge 1 commit into
Conversation
…t as prereq The network layer applied aviatrix_distributed_firewalling_config.enable directly, toggling Distributed Cloud Firewall on for the entire controller. DCF's enable state is a controller-wide singleton, not a per-blueprint resource — on a shared controller this fights other tenants managing the same setting, and on terraform destroy it attempts to disable DCF globally, breaking every other blueprint's DCF policies on that controller. Remove the resource (and its stray depends_on reference) and document enabling DCF as a one-time, out-of-band prerequisite in the README instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
networklayer of this blueprint appliedaviatrix_distributed_firewalling_config.enabledirectly, which toggles Distributed Cloud Firewall on for the entire controller, not just this blueprint's resources.DCF's enable state is a controller-wide singleton. On a controller shared by multiple blueprints/tenants, this causes two problems:
terraform destroyon this blueprint attempts to disable DCF globally, which can fail (AVXERR-DFW-0008) if other tenants have active DCF policies, or worse, succeed and silently break every other blueprint's DCF enforcement on that controller.This PR removes the resource (and its now-stray
depends_onreference inaviatrix_dcf_ruleset.aks_demo) and documents enabling DCF as a one-time, out-of-band prerequisite in the README's Prerequisites table — consistent with how other controller-wide singletons (account onboarding, etc.) are already treated as prerequisites rather than blueprint-managed resources.Type of Change
Blueprint Checklist (for new or modified blueprints)
Documentation
Code Quality
terraform fmtpassesterraform validatepassessensitive = true— unaffectedvar.name_prefix— unaffectedTesting
terraform fmt/validateonly (this is a resource removal + doc change, no new resources)Catalog Update
Control Plane Version Tested
terraform validateagainst provider~> 8.2)Cloud Environment
Additional Notes
For users who already applied this blueprint before this change: on your next
terraform apply, Terraform will propose to destroyaviatrix_distributed_firewalling_config.enable. Since DCF's enable state is idempotent and controller-wide, allowing that destroy is safe and will not disable DCF as long as any other config/blueprint on the controller still has DCF-dependent resources (it only removes this blueprint's management of the setting, not the setting itself, unless nothing else references it). If you want to be extra cautious, runterraform state rm aviatrix_distributed_firewalling_config.enableinstead of letting apply destroy it.🤖 Generated with Claude Code