Fix - Complete window dialog task when dialog is hidden

[emmauss]

What does the pull request do?

• When a dialog window is hidden, sets the task returned with ShowDialog as complete.
• Fixes an issue where the parent window would be moved down the z-order when a dialog window was hidden

What is the current behavior?

When a dialog window is shown, a task is return for user to wait on. This task is set to completed on Close, but not on Hide, even though the owner is set to null when hidden. This makes any thread waiting on the window to lock up.

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

[avaloniaui-bot]

You can test this PR using the following package version. 11.3.999-cibuild0054544-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[kekekeks]

Don't we also need to update "this window has child modal dialogs" state for dialog parent?

[kekekeks]

Nvm, Owner is already set to null in Hide.

[MrJul]

@emmauss the fix looks good but a matching unit test should probably be added.

Note: we already have a test WindowTests.IsVisible_Should_Close_DialogWindow.
Maybe the implementation could simply be changed so that Hide() calls Close() if the dialog is modal, which is what happens when IsVisible is set to false?

[emmauss]

WindowTests.IsVisible_Should_Close_DialogWindow

Made Hide and IsVisible=false behave the same for all window types, i.e. they hide the window and not close it. Also updated tests.

[avaloniaui-bot]

You can test this PR using the following package version. 11.3.999-cibuild0054737-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[avaloniaui-bot]

You can test this PR using the following package version. 11.3.999-cibuild0054741-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[avaloniaui-bot]

You can test this PR using the following package version. 11.3.999-cibuild0054753-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[MrJul]

LGTM!