fix(user-activity-broadcaster): determine the correct origin to postMessage#874
Open
TheSharpieOne wants to merge 1 commit intomasterfrom
Open
fix(user-activity-broadcaster): determine the correct origin to postMessage#874TheSharpieOne wants to merge 1 commit intomasterfrom
TheSharpieOne wants to merge 1 commit intomasterfrom
Conversation
TheSharpieOne
requested review from
LauRoxx,
chrishavekost,
gregmartDOTin,
jordan-a-young and
nylon22
as code owners
owolfhu1
previously approved these changes
Jul 16, 2025
TheSharpieOne
force-pushed
the
fix/user-activity-broadcaster
branch
2 times, most recently
from
9d84120 to
52c4bf7
Compare
TheSharpieOne
force-pushed
the
fix/user-activity-broadcaster
branch
from
52c4bf7 to
2813f6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this would change origin from "essentials" to "apps" assuming that all essentials applications are iframed into the apps domain. This is not always the case anymore as environments have migrated.
Really, this didn't validate the domain, any domain that contained "essentials" or "apps" could be used, including something like "essentials.malicious.com" (which would postMessage to "apps.malicious.com")
Also, not 100% sure why there was the case for the opposite of "apps" to "essentials" since the seems like it could never be the case.
With this change, it will now validate the iframe's parent domain before it uses it as the origin. This works for when essentials is iframed into apps as well as when essentials is iframed into essentials and any time this is iframed into an availity domain.