Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat sender avatar #1800

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Chat sender avatar #1800

merged 2 commits into from
Sep 18, 2024

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Sep 18, 2024

show_sender default to False
sender avatar right aligned
resolves #1798

show_sender default to False
resolves #1798
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 📈 Improvement Improvement of a feature. GUI: Front-End labels Sep 18, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Sep 18, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.05362776025237%

St.
Category Percentage Covered / Total
🟢 Statements
87.65% (+0% 🔼)
3193/3643
🟡 Branches
69.05% (-0.04% 🔻)
2189/3170
🟢 Functions 82.67% 582/704
🟢 Lines
88.22% (+0% 🔼)
2957/3352
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Chat.tsx
90.08% (+0.08% 🔼)
69.17% (-1.01% 🔻)
79.17%
91.41% (+0.07% 🔼)

Test suite run success

642 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 325863a

Copy link
Contributor

github-actions bot commented Sep 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19324 16269 84% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/factory.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 2ed5163 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga merged commit 2950106 into develop Sep 18, 2024
159 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#1798-chat-sender-avatar branch September 18, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be addressed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat control default appearance
3 participants