Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/#64 fixed broken issue due to MigrationConfig being moved out of core #65

Merged
merged 3 commits into from
Sep 21, 2024
Merged

feature/#64 fixed broken issue due to MigrationConfig being moved out of core #65

merged 3 commits into from
Sep 21, 2024
+19 −38

Conversation

toan-quach
Copy link
Member

#64

jrobinAV
jrobinAV previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess we need the opposite PR on enterprise. right? or is it already done?

@jrobinAV jrobinAV self-requested a review September 12, 2024 14:55
@jrobinAV
Copy link
Member

It seems we have broken tests in windows Python 3.12. No?

@trgiangdo trgiangdo merged commit 2202246 into develop Sep 21, 2024
3 of 4 checks passed
@trgiangdo trgiangdo deleted the bug/#64-fix-broken-tests-MigrationConfig-being-moved-out branch September 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trgiangdo trgiangdo trgiangdo approved these changes

@jrobinAV jrobinAV jrobinAV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toan-quach @jrobinAV @trgiangdo