Develop #223
Merged
Develop #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Exanthiax
commented
Dec 29, 2025
Exanthiax
commented
- Fixed error when taking non-living entity damage with MythicMobs (Thanks OfTeN!)
- Fixed permament potion effects remaining indefinitely (Thanks Exanthiax!)
- Added duration arg to spawn_potion_cloud effect (Thanks ryzech!)
- Fixed on_ground and in_air conditions (Thanks 0x484!)
…t cause an error with TriggerTakeDamage anymore
This PR improves the permanent_potion_effect effect. - Fixes an issue where permanent potion effects are never removed when conditions/holders change. - Improved reapplying potion effects on change of holders. Swapping items around with perm effects is much more consistent.
Update EffectPermanentPotionEffect.kt
Set cloud duration, according to the effect duration.
Fix on_ground condition, Change in_air condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.