Skip to content

Conversation

@NicoNekoDev
Copy link
Contributor

@NicoNekoDev NicoNekoDev commented Nov 14, 2025

Pattern.equals() compares the references to the objects, i.e. uses the == operator. This is not good, because a new Pattern is created for the new placeholder, so the above mentioned method throws false even tho it's the same pattern.
https://stackoverflow.com/a/10055112
This fixes the issue with reloading libreforge's custom conditional placeholders that did not work correctly.

@NicoNekoDev NicoNekoDev requested a review from WillFP as a code owner November 14, 2025 11:28
@Exanthiax Exanthiax changed the base branch from master to develop December 29, 2025 22:30
@Exanthiax Exanthiax merged commit 7de8a23 into Auxilor:develop Dec 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants