Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Connections: Fix bug with service examples #97332

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Social Connections: Fix bug with service examples #97332

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8f1a7c
Add all service ID to SERVICES_WITH_EXAMPLES
gmjuhasz Dec 11, 2024
a90a400
Add remaining services
gmjuhasz Dec 11, 2024
0a26bdf
Update client/sites/marketing/connections/service-examples.jsx
gmjuhasz Dec 13, 2024
17d644c
Merge branch 'trunk' into fix/social-connections-panel-examples
gmjuhasz Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion client/sites/marketing/connections/service-examples.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,25 @@ import './service-examples.scss';
* a method with the example's content.
* @type {string[]}
*/
export const SERVICES_WITH_EXAMPLES = [ 'google_plus', 'mastodon', 'bluesky' ];
export const SERVICES_WITH_EXAMPLES = [
'bandpage',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we got any services without examples? Perhaps we should flip this logic, although it will be going away soon.

'bluesky',
'facebook',
'google-drive',
'google_my_business',
'google_photos',
'google_plus',
'instagram-basic-display',
'instagram-business',
'linkedin',
'mailchimp',
'mastodon',
'nextdoor',
'p2_github',
'p2_slack',
'threads',
'tumblr',
];

class SharingServiceExamples extends Component {
static propTypes = {
Expand Down
Loading