Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Implement VIP hosting page v3. #97265

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jkguidaven
Copy link
Contributor

This PR implements the new WPCOM hosting section v3 (feature list, testimonials & CTA section).

Screenshot 2024-12-10 at 6 33 10 PM

Depends on #97230
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1556
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1557
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1558

Proposed Changes

  • Implement the 'Feature list', 'Testimonials', and 'CTA' sections.

Why are these changes being made?

  • This is part of the In-product hosting page v3 project.

Testing Instructions

  • Use the A4A live link and go to the /marketplace/hosting/vip page.
  • Confirm you see the new sections.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven requested a review from a team December 10, 2024 10:33
@jkguidaven jkguidaven self-assigned this Dec 10, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 10, 2024
@jkguidaven jkguidaven marked this pull request as ready for review December 10, 2024 10:34
@matticbot
Copy link
Contributor

matticbot commented Dec 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1736 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace      +4176 B  (+0.5%)    +1701 B  (+0.7%)
a8c-for-agencies-migrations        +107 B  (+0.0%)      +35 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jkguidaven jkguidaven force-pushed the add/a4a/wpcom-hosting-page-v3 branch from f90e481 to eca52f2 Compare December 11, 2024 05:03
@jkguidaven jkguidaven force-pushed the add/a4a/vip-hosting-page-v3 branch from 3e7256b to 59022f2 Compare December 11, 2024 05:07
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/vip-hosting-page-v3 on your sandbox.

Base automatically changed from add/a4a/wpcom-hosting-page-v3 to trunk December 11, 2024 08:16
@jkguidaven jkguidaven force-pushed the add/a4a/vip-hosting-page-v3 branch from 59022f2 to ad3f593 Compare December 11, 2024 08:19
@jkguidaven jkguidaven force-pushed the add/a4a/vip-hosting-page-v3 branch from ad3f593 to ca5002f Compare December 11, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants