Fix spacing issue with billing timeframe on cloud backup upsell #97188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
NOTE: I audited all other uses of the
<TimeFrame />
component and this issue doesn't seem to be present anywhere else as all other uses I could find use the<TimeFrame />
component separate from the price itself and apply spacing via CSS. This seem to be the only case where it is inserted into a translated string in this way. Therefore this issue shouldn't be present anywhere elseWhy are these changes being made?
There is a space missing between the price and timeframe in this upsell
Testing Instructions
yarn start-jetpack-cloud
client/components/backup-storage-space/usage-warning/use-storage-status-text.ts
Update line 29 to
client/components/backup-storage-space/index.tsx
Update line 56 to
http://jetpack.cloud.localhost:3001/backup/{your-test-site}
Pre-merge Checklist