Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issue with billing timeframe on cloud backup upsell #97188

Merged

Conversation

CodeyGuyDylan
Copy link
Contributor

Proposed Changes

  • Fix the spacing issue present on the cloud backups upsell when displaying the price of additional storage.

NOTE: I audited all other uses of the <TimeFrame /> component and this issue doesn't seem to be present anywhere else as all other uses I could find use the <TimeFrame /> component separate from the price itself and apply spacing via CSS. This seem to be the only case where it is inserted into a translated string in this way. Therefore this issue shouldn't be present anywhere else

Why are these changes being made?

There is a space missing between the price and timeframe in this upsell
image

Testing Instructions

  1. Checkout this branch locally
  2. Start up Jetpack cloud with yarn start-jetpack-cloud
  3. Connect your site with a site and user connection
  4. Create a testing JN site and, in whatever way you'd like, add a paid Jetpack Backup plan to it.
  5. Go to client/components/backup-storage-space/usage-warning/use-storage-status-text.ts
    Update line 29 to
default:
  1. Go to client/components/backup-storage-space/index.tsx
    Update line 56 to
const showUpsell = true;
  1. Now go to http://jetpack.cloud.localhost:3001/backup/{your-test-site}
  2. You should see the upsell with the space present

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/spacing-issue-with-billing-timeframe-cloud-backups on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@CodeyGuyDylan CodeyGuyDylan merged commit 17afd38 into trunk Dec 6, 2024
12 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the fix/spacing-issue-with-billing-timeframe-cloud-backups branch December 6, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants