Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stats: Show feedback prompts to sites with 10k+ visitors per month" #97164

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Dec 6, 2024

Reverts #97015 — Actually planning to ship these changes next week.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-97015-update/stats-feedback-10k-plus on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~249 bytes removed 📉 [gzipped])

name   parsed_size           gzip_size
stats       -804 B  (-0.1%)     -249 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ck3n a8ck3n marked this pull request as ready for review December 6, 2024 09:20
@a8ck3n a8ck3n requested a review from a team December 6, 2024 09:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@a8ck3n a8ck3n merged commit 58aeca9 into trunk Dec 6, 2024
14 checks passed
@a8ck3n a8ck3n deleted the revert-97015-update/stats-feedback-10k-plus branch December 6, 2024 09:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 6, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17049514

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @a8ck3n, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Help us make Jetpack better

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Dec 6, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants