Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Enable tab switching for unsupported fields of hourly views #97163

Merged

Conversation

dognose24
Copy link
Contributor

Related to https://github.com/Automattic/red-team/issues/301.

Proposed Changes

  • Restore chart tab switching for tab Visitors, Likes, and Comments.
  • Use NULL to recognize unsupported Stats visits fields for hourly views to apply alternative data.

Why are these changes being made?

Testing Instructions

  • Apply Diff D167991-code and sandbox public-api.wordpress.com.
  • Navigate to Stats > Traffic with the feature flag: ?flags=stats/new-date-filtering.
  • Click on any day on the chart to navigate to the hourly views.
  • Ensure the Views tab works as previously.
截圖 2024-12-06 下午2 58 22
  • Ensure the Visitors, Likes, and Comments tabs are clickable.
  • Click on the Visitors tab.
  • Ensure the chart is showing empty state with hourly views dedicated texts.
  • Ensure the chart tab still displays the cumulative number of visitors for a single day.
截圖 2024-12-06 下午2 58 05

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dognose24 dognose24 added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 6, 2024
@dognose24 dognose24 requested a review from a team December 6, 2024 07:54
@dognose24 dognose24 self-assigned this Dec 6, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 6, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~52 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +101 B  (+0.0%)      +52 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~11 bytes removed 📉 [gzipped])

name                              parsed_size           gzip_size
async-load-store-app-store-stats        -37 B  (-0.0%)      -11 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -31,7 +31,8 @@ class StatsTabs extends Component {
} else {
data?.map( ( day ) =>
tabs.map( ( tab ) => {
if ( isFinite( day[ tab.attr ] ) ) {
// Exclude non-numeric values, e.g., NULL from unsupported stats fields.
if ( Number.isFinite( day[ tab.attr ] ) ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isFinite( null ) === true
Number.isFinite( null ) === false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm that's why we love JavaScript right? 🥲

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kangzj kangzj merged commit d8841b5 into trunk Dec 8, 2024
14 of 15 checks passed
@kangzj kangzj deleted the update/stats_use_empty_state_for_unsupported_hourly_views branch December 8, 2024 21:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 8, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 8, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17054550

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @dognose24 for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants