-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Woo branding for reset password pages #97152
Open
ilyasfoo
wants to merge
4
commits into
trunk
Choose a base branch
from
update/woo-rebrand-auth-reset-password
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−32
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
91ca463
Add changes for reset password and fixes so rebrand styling update do…
ilyasfoo cabbb81
Use oauth class instead for more precise selector
ilyasfoo 4fe5873
Merge remote-tracking branch 'origin/trunk' into update/woo-rebrand-a…
ilyasfoo 158aca2
Update test
ilyasfoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ const LostPasswordForm = ( { | |
onSubmit={ onSubmit } | ||
> | ||
<div className="login__form-userdata"> | ||
<FormLabel htmlFor="email">{ translate( 'Your email address' ) }</FormLabel> | ||
<FormLabel htmlFor="email">{ translate( 'Your email' ) }</FormLabel> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Meant to be outside of feature flag |
||
<FormTextInput | ||
autoCapitalize="off" | ||
autoCorrect="off" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ describe( 'LostPasswordForm', () => { | |
test( 'displays a lost password form without errors', () => { | ||
render( <LostPasswordForm redirectToAfterLoginUrl="" oauth2ClientId="" locale="" /> ); | ||
|
||
const email = screen.getByLabelText( /Your email address/i ); | ||
const email = screen.getByLabelText( /Your email/i ); | ||
expect( email ).toBeInTheDocument(); | ||
|
||
const btn = screen.getByRole( 'button', { name: /Reset my password/i } ); | ||
|
@@ -27,10 +27,7 @@ describe( 'LostPasswordForm', () => { | |
test( 'displays an error message when email is invalid', async () => { | ||
render( <LostPasswordForm redirectToAfterLoginUrl="" oauth2ClientId="" locale="" /> ); | ||
|
||
await userEvent.type( | ||
screen.getByRole( 'textbox', { name: 'Your email address' } ), | ||
'invalid email' | ||
); | ||
await userEvent.type( screen.getByRole( 'textbox', { name: 'Your email' } ), 'invalid email' ); | ||
// The error message is displayed after the user blurs the input. | ||
userEvent.tab(); | ||
|
||
|
@@ -46,7 +43,7 @@ describe( 'LostPasswordForm', () => { | |
render( <LostPasswordForm redirectToAfterLoginUrl="" oauth2ClientId="" locale="" /> ); | ||
|
||
await userEvent.type( | ||
screen.getByRole( 'textbox', { name: 'Your email address' } ), | ||
screen.getByRole( 'textbox', { name: 'Your email' } ), | ||
'[email protected]' | ||
); | ||
// The error message is displayed after the user blurs the input. | ||
|
@@ -59,15 +56,12 @@ describe( 'LostPasswordForm', () => { | |
test( 'reset error message when email is valid', async () => { | ||
render( <LostPasswordForm redirectToAfterLoginUrl="" oauth2ClientId="" locale="" /> ); | ||
|
||
await userEvent.type( | ||
screen.getByRole( 'textbox', { name: 'Your email address' } ), | ||
'invalid email' | ||
); | ||
await userEvent.type( screen.getByRole( 'textbox', { name: 'Your email' } ), 'invalid email' ); | ||
// The error message is displayed after the user blurs the input. | ||
userEvent.tab(); | ||
|
||
await userEvent.type( | ||
screen.getByRole( 'textbox', { name: 'Your email address' } ), | ||
screen.getByRole( 'textbox', { name: 'Your email' } ), | ||
'[email protected]' | ||
); | ||
// The error message is displayed after the user blurs the input. | ||
|
@@ -81,14 +75,11 @@ describe( 'LostPasswordForm', () => { | |
test( 'reset error message when email is empty', async () => { | ||
render( <LostPasswordForm redirectToAfterLoginUrl="" oauth2ClientId="" locale="" /> ); | ||
|
||
await userEvent.type( | ||
screen.getByRole( 'textbox', { name: 'Your email address' } ), | ||
'invalid email' | ||
); | ||
await userEvent.type( screen.getByRole( 'textbox', { name: 'Your email' } ), 'invalid email' ); | ||
// The error message is displayed after the user blurs the input. | ||
userEvent.tab(); | ||
|
||
await userEvent.clear( screen.getByRole( 'textbox', { name: 'Your email address' } ) ); | ||
await userEvent.clear( screen.getByRole( 'textbox', { name: 'Your email' } ) ); | ||
// The error message is displayed after the user blurs the input. | ||
userEvent.tab(); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to be outside of feature flag