-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Big Sky steps #97150
base: trunk
Are you sure you want to change the base?
Update Big Sky steps #97150
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@kthai15 , what do you mean by |
Yea, I wasn't sure if the progress bar had a different look or progress animation than what is being used in the vanilla component. There may have been a mention of this in the figma. |
Fixed the animation issue, it's todo with how the component is recreated on every render. See my P2 post. |
5460ad3
to
06c054d
Compare
@dereksmart @kthai15 Please give this a test/review, so we can merge and then be able to test end-to-end from Calypso to Big Sky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve this, but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's roll!
Proposed Changes
Implement design updates to the design choices step and launch step for Big Sky
Testing Instructions
http://calypso.localhost:3000/setup/site-setup/design-choices?siteSlug=YOUR_SUPPORTED_SITE_SLUG
Pre-merge Checklist