Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Big Sky steps #97150

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from
Open

Update Big Sky steps #97150

wants to merge 14 commits into from

Conversation

kthai15
Copy link
Contributor

@kthai15 kthai15 commented Dec 6, 2024

Proposed Changes

Implement design updates to the design choices step and launch step for Big Sky


Testing Instructions

http://calypso.localhost:3000/setup/site-setup/design-choices?siteSlug=YOUR_SUPPORTED_SITE_SLUG

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kthai15 kthai15 changed the title Update/big sky step Update Big Sky steps Dec 6, 2024
@kthai15 kthai15 self-assigned this Dec 6, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/big-sky-step on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@benzhu56
Copy link
Contributor

@kthai15 , what do you mean by progress bar animation?
The progress bar does have animation when the value is changed. Are you thinking about making it look smoother?

@benzhu56 benzhu56 self-assigned this Feb 12, 2025
@kthai15
Copy link
Contributor Author

kthai15 commented Feb 12, 2025

The progress bar does have animation when the value is changed. Are you thinking about making it look smoother?

Yea, I wasn't sure if the progress bar had a different look or progress animation than what is being used in the vanilla component. There may have been a mention of this in the figma.

@benzhu56 benzhu56 marked this pull request as ready for review February 12, 2025 06:15
@benzhu56
Copy link
Contributor

benzhu56 commented Feb 12, 2025

Fixed the animation issue, it's todo with how the component is recreated on every render. See my P2 post.

@benzhu56 benzhu56 requested a review from a team as a code owner February 25, 2025 00:50
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 25, 2025
@benzhu56 benzhu56 force-pushed the update/big-sky-step branch from 5460ad3 to 06c054d Compare February 27, 2025 07:03
@benzhu56
Copy link
Contributor

@dereksmart @kthai15 Please give this a test/review, so we can merge and then be able to test end-to-end from Calypso to Big Sky.

@alshakero alshakero removed the request for review from a team February 27, 2025 11:48
Copy link
Contributor Author

@kthai15 kthai15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this, but LGTM

Copy link
Contributor

@benzhu56 benzhu56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants