-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable bloganuary #97136
Disable bloganuary #97136
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~18 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
const BLOGANUARY_ENABLED = false; | ||
if ( ! BLOGANUARY_ENABLED ) { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use return false
here? ..... alternatively we can use moment
and if the year is 2025
then return false
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could return false
, but then I'd need to rip out most of the code here (which the issue asked that we not do). I wanted to make it clearer that this was intentional and preserve the current return logic.
We could check for 2025, but I'm worried we'll forget to disable it for 2026. 😂
Related to https://github.com/Automattic/loop/issues/242
Proposed Changes
Why are these changes being made?
Testing Instructions
return: true;
Pre-merge Checklist