-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: Disable longer plan term default in logged-in plans page #97129
Plans: Disable longer plan term default in logged-in plans page #97129
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~64 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Ah yes this was on my radar of personal TODO's. I spotted the code some time after I merged #96816 and was planning to do a quick clean up among other things ( happiness heads up, stakeholder heads up, issue creation for bugs and potential refactors etc. ) before deploying to production. I'll start elaborating on all of the remaining tasks I have in mind more clearly today. In the meantime, thanks for taking care of this Christos 🙏 |
Started updating https://github.com/Automattic/martech/issues/3403 with a more comprehensive list of remaining and optional tasks |
TestingRequirements
Flows:
Browsers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well. On my way home from the coffee shop. Merging this when I arrive. Thanks again for drafting this Christos! 😄
Related to #96816, https://github.com/Automattic/martech/issues/3403
Related to p1732646141389969-slack-CV2TX2PAN and p1732648406144139-slack-CV2TX2PAN
Proposed Changes
This is a follow-up to #96816 where we disabled the term savings display for the logged-in plans page. That was only a part of the upcoming experiment. We disable the longer plan term default here as that's the main/core of the upcoming experiment, not the term savings display.
Why are these changes being made?
The same reasoning with #96816
Testing Instructions
/plans/:site
and ensure it doesn't default to a longer plan term, like 2-yearly or 3-yearly depending on variationPre-merge Checklist