Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vdimitrakis/promoted posts translations #97126

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

therocket-gr
Copy link
Contributor

we have updated a few strings in the DSP widget

Related to 2718-gh-tumblr/a8c-dsp

Proposed Changes

this is just a string translations PR

there are a few so I will add as many screenshots for reference as I can, hoping that I include everything

if not and there is something that lacks reference ping me so that I can provide more info

Screenshot 2024-12-05 at 6 58 05 PM Screenshot 2024-12-05 at 6 56 56 PM Screenshot 2024-12-05 at 6 56 51 PM Screenshot 2024-12-05 at 6 59 19 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@therocket-gr therocket-gr requested a review from jjolmo December 5, 2024 17:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug vdimitrakis/promoted-posts-translations on your sandbox.

@therocket-gr therocket-gr requested review from j6ll and timur987 December 5, 2024 17:02
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@therocket-gr therocket-gr merged commit 5a1b988 into trunk Dec 6, 2024
16 checks passed
@therocket-gr therocket-gr deleted the vdimitrakis/promoted-posts-translations branch December 6, 2024 14:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 6, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17049989

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @therocket-gr for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 12, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants