-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Filter main feed based on sidebar selection #97123
Reader: Filter main feed based on sidebar selection #97123
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~249 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~105 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good and we can roll forward with this.
I did stub out another approach that addresses some of the issues like the feeds overwriting each other if selections are made in quick succession. Here's the branch if you want to take a look. It's just prototype code but might be a direction we could take.
I fixed some TS errors that were related to the analytics calls, and I also suggest we remove the VSCode debug configs from this PR to keep this one tidy.
9a485ca
to
214e072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well!
- Feed is filtering by selection
- I can't trigger the "overriding feeds" issue 👍
Related to https://github.com/Automattic/loop/issues/236
Proposed Changes
Recent
menu item on sidebar with the list of subscribed posts which have also made it consistent with the new designs./following
API calls to include the selectedfeed_id
.Why are these changes being made?
To enhance the filtering capabilities for feeds within the Reader's "stream" view.
Testing Instructions
/read
/read?flags=reader%2Frecent-feed-overhaul
and select thestream
viewPre-merge Checklist