Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site logs: hide unexpected pagination numbers #97097

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Dec 5, 2024

Fixes #92668

Proposed Changes

This PR restores the behavior of the original PR that introduced the pagination for site logs:

The pagination is supposed to only show Prev and Next buttons, without any page numbers, due to the limitation of the backend endpoint. The above PR does that by hiding the page numbers via CSS. I believe, we broke that CSS somehow when we moved the feature to the Hosting Dashboard.

Before After
image image

Why are these changes being made?

Fixes a regression.

Testing Instructions

  1. Go to /sites?flags=-untangling/hosting-menu
  2. Click an Atomic site.
  3. Click Logs tab.
  4. Click the Web server subtab (so that you can see bunch of logs already)
  5. Scroll down and check that the Prev/Next pagination controls are working.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix-site-logs-pagination on your sandbox.

@fushar fushar marked this pull request as ready for review December 5, 2024 03:23
@fushar fushar self-assigned this Dec 5, 2024
@fushar fushar requested a review from a team December 5, 2024 03:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! LGTM.

Copy link
Contributor

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fushar fushar merged commit 35520e2 into trunk Dec 6, 2024
17 of 25 checks passed
@fushar fushar deleted the fix-site-logs-pagination branch December 6, 2024 02:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Logs: Pagination for Requests Broken
4 participants