-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site logs: hide unexpected pagination numbers #97097
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #92668
Proposed Changes
This PR restores the behavior of the original PR that introduced the pagination for site logs:
The pagination is supposed to only show Prev and Next buttons, without any page numbers, due to the limitation of the backend endpoint. The above PR does that by hiding the page numbers via CSS. I believe, we broke that CSS somehow when we moved the feature to the Hosting Dashboard.
Why are these changes being made?
Fixes a regression.
Testing Instructions
Pre-merge Checklist