Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow primary field container to fill available space #97081

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Dec 4, 2024

Fixes Automattic/loop#237

Proposed Changes

Enable the post title and featured image container to fill unused space so post titles and images are aligned

Before After
image image

Why are these changes being made?

pe7F0s-2iv-p2

Testing Instructions

  • Vist read?flags=reader/recent-feed-overhaul
  • Select a feed where posts have featured images
  • Resize screen to make sure images are always aligned to the right of the column

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/reader-recent-items-img on your sandbox.

@holdercp holdercp self-assigned this Dec 4, 2024
@holdercp holdercp marked this pull request as ready for review December 4, 2024 19:46
@holdercp holdercp requested a review from a team as a code owner December 4, 2024 19:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change the featured images are always aligned right as I resize the window:

Screen Shot 2024-12-04 at 3 06 56 PM

@holdercp holdercp merged commit a594f93 into trunk Dec 4, 2024
14 checks passed
@holdercp holdercp deleted the fix/reader-recent-items-img branch December 4, 2024 20:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* Allow primary field container to fill available space

* Remove old todo comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants