-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Migration: Update Plans page for migrations flow #97062
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1197 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Thanks for getting this started @sixhours! I saw your comments about the visual tweaks so I'll hold off on those comments. I don't know if you caught this but the back button covers some of the content on mobile. We might need to artificially add some space to account for it: |
@fditrapani I'll take a look! Feel free to hit me up with any other visual feedback, too. I had a question about the refund copy placement; it changes depending on the frequency (monthly gets up to 7 days, the others up to 14 days) so I left it in the old spot. Let me know if that should move. I also wasn't sure if you wanted the plan details auto-expanded like they are right now or not. |
This is coming along nicely @sixhours ! Screen.Recording.2024-12-05.at.10.05.44.AM.movI've also added the string freeze label so translation starts |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17047877 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators. |
5f58e52
to
c3974fc
Compare
@fditrapani I think this is ready for another look 👀 :) The features are currently served from the same set of feature constants we use for all plans for consistency. If we want to customize them for migrations we'll probably need to hard-code them just for this screen. |
Thanks @sixhours! I don't mind if we do it in a separate PR but let's go ahead and customize them for here only. There are specific differences we want to call out for each option and I hand picked the features to cater to our migration audience too. |
I can take a closer look at the updates a little later today or by tomorrow the latest! |
@fditrapani Is the annual savings % discount mentioned in the features consistent or is it dependent on the currency/location? 🤔 |
That's a good question! @bohdankit07 @niranjan-uma-shankar would either of you know if our annual discounts are consistent across currencies? |
Nice work on this @sixhours! I found two minor things: |
a127065
to
4cc1f09
Compare
02a4df4
to
184d049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I removed the String Freeze label since this will be deployed behind a feature flag. We should make sure that everything is translated when this is shipped.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17047877 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators. |
Proposed Changes
migration-flow/experiment
feature flag istrue
.Why are these changes being made?
Testing Instructions
window.sessionStorage.setItem('flags', 'migration-flow/experiment');
window.sessionStorage.setItem('flags', false);
and reload the screen.Pre-merge Checklist