Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Update Plans page for migrations flow #97062

Merged
merged 49 commits into from
Dec 11, 2024

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Dec 4, 2024

Proposed Changes

  • Add monthly and biennial plans to the importer upgrade step, shown only when the migration-flow/experiment feature flag is true.
  • Since the upgrade step is mostly hard-coded to the Business plan, this adds panels on either side of the main plan with monthly and biennial plan details.
  • Updates the loader to better resemble the new content being loaded.
  • Lots of visual tweaks to better match the mockup at ay0fZYgdXxPDbZbgPlz3hu-fi-1_3529
  • Still to do: Consider this a first draft, please. :) Updating tests, making any visual tweaks, etc. still need to be done.

Why are these changes being made?

  • p9Jlb4-fiH-p2

Testing Instructions

  • Switch to this branch locally or via calypso.live
  • Set the feature flag in session storage via the console and reload: window.sessionStorage.setItem('flags', 'migration-flow/experiment');
  • Go through the migration flow until you get to the upgrade step
  • It should look like this with the flag enabled:

calypso localhost_3000_setup_site-migration_site-migration-upgrade-plan_siteId=239588599 siteSlug=testing2026 wordpress com from=https%3A%2F%2Fthemeflailing mystagingwebsite com%2F destination=upgrade how=myself (1)

  • Ensure the Monthly/Yearly/Biennially buttons add the correct products to the cart, respectively, and the prices match.
  • Disable the flag in session storage: window.sessionStorage.setItem('flags', false); and reload the screen.
  • You should see the original screen, and it should work as expected:
Screenshot 2024-12-04 at 3 09 18 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sixhours sixhours self-assigned this Dec 4, 2024
@sixhours sixhours requested a review from a team as a code owner December 4, 2024 15:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@sixhours sixhours marked this pull request as draft December 4, 2024 15:04
@sixhours sixhours removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plans-page-behind-flag on your sandbox.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1197 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow      +5680 B  (+0.7%)    +1223 B  (+0.5%)
import                        -103 B  (-0.0%)      -26 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sixhours sixhours requested review from fditrapani and a team December 4, 2024 20:10
@sixhours sixhours marked this pull request as ready for review December 4, 2024 20:12
@fditrapani
Copy link
Contributor

Thanks for getting this started @sixhours! I saw your comments about the visual tweaks so I'll hold off on those comments. I don't know if you caught this but the back button covers some of the content on mobile. We might need to artificially add some space to account for it:

image

@sixhours
Copy link
Contributor Author

sixhours commented Dec 4, 2024

@fditrapani I'll take a look! Feel free to hit me up with any other visual feedback, too.

I had a question about the refund copy placement; it changes depending on the frequency (monthly gets up to 7 days, the others up to 14 days) so I left it in the old spot. Let me know if that should move.

I also wasn't sure if you wanted the plan details auto-expanded like they are right now or not.

@andres-blanco andres-blanco added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 5, 2024
@andres-blanco
Copy link
Contributor

This is coming along nicely @sixhours !
I noticed screen flicker between the skeletons. Maybe this is due to Calypso not picking up the feature flag on time, but worth looking into it.

Screen.Recording.2024-12-05.at.10.05.44.AM.mov

I've also added the string freeze label so translation starts

@a8ci18n
Copy link

a8ci18n commented Dec 5, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17047877

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators.

@fditrapani
Copy link
Contributor

I noticed screen flicker between the skeletons. Maybe this is due to Calypso not picking up the feature flag on time, but worth looking into it.

I didn't see this extra state because mine loaded before it flipped. I agree that we need to not show the old layout.

Feel free to hit me up with any other visual feedback, too.

Sure. I'll let you get things closer to finished before getting too fine grained but there were alignment issues and the contents of the plans, and offers, need to be updated for the migration audience. Let me know if you want to pair on a session to go through this stuff together. Happy to do it on a call if it's easier.

I had a question about the refund copy placement; it changes depending on the frequency (monthly gets up to 7 days, the others up to 14 days) so I left it in the old spot. Let me know if that should move.

Good catch. I didn't notice that. What if we add a "feature" for the refund duration and make the copy below generic like this:
image

I also wasn't sure if you wanted the plan details auto-expanded like they are right now or not.

I'm fine with leaving that out since I cherry picked the top features this audience. We recently updated our regular plan onboarding flow to show less features and it did better than showing everything.

@sixhours sixhours force-pushed the update/plans-page-behind-flag branch from 5f58e52 to c3974fc Compare December 5, 2024 16:11
@sixhours
Copy link
Contributor Author

sixhours commented Dec 5, 2024

@fditrapani I think this is ready for another look 👀 :)

The features are currently served from the same set of feature constants we use for all plans for consistency. If we want to customize them for migrations we'll probably need to hard-code them just for this screen.

@fditrapani
Copy link
Contributor

Thanks @sixhours! I don't mind if we do it in a separate PR but let's go ahead and customize them for here only. There are specific differences we want to call out for each option and I hand picked the features to cater to our migration audience too.

@fditrapani
Copy link
Contributor

I can take a closer look at the updates a little later today or by tomorrow the latest!

@sixhours sixhours added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Dec 5, 2024
@sixhours
Copy link
Contributor Author

sixhours commented Dec 5, 2024

@fditrapani Is the annual savings % discount mentioned in the features consistent or is it dependent on the currency/location? 🤔

@fditrapani
Copy link
Contributor

@fditrapani Is the annual savings % discount mentioned in the features consistent or is it dependent on the currency/location?

That's a good question! @bohdankit07 @niranjan-uma-shankar would either of you know if our annual discounts are consistent across currencies?

@fditrapani
Copy link
Contributor

Nice work on this @sixhours! I found two minor things:

  1. There's a weird alignment issue that's causing things to be off ever so slightly:
    image
    It's weird because it corrects itself and then goes out of alignment again.

  2. The main CTA is using an off white colour:
    image

@sixhours sixhours force-pushed the update/plans-page-behind-flag branch from a127065 to 4cc1f09 Compare December 9, 2024 14:29
@sixhours sixhours force-pushed the update/plans-page-behind-flag branch from 02a4df4 to 184d049 Compare December 10, 2024 13:47
@andres-blanco andres-blanco removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 11, 2024
Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I removed the String Freeze label since this will be deployed behind a feature flag. We should make sure that everything is translated when this is shipped.

@sixhours sixhours merged commit f85d691 into trunk Dec 11, 2024
11 checks passed
@sixhours sixhours deleted the update/plans-page-behind-flag branch December 11, 2024 17:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17047877

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants