Skip to content

Conversation

dognose24
Copy link
Contributor

This is the follow-up for #96869.

Proposed Changes

  • Fix the chart end date when it is determined by the forced 7 days by the feature gate.

Why are these changes being made?

  • We need a complete range for all shortcuts.

Testing Instructions

  • Spin this change up with Calypso Live branch.
  • Navigate to Stats > Traffic page for a Simplte site created after 2024-01-09 with the feature flag: ?flags=stats/new-date-filtering.
  • Ensure the default date range is applied to the Last 7 Days and the selected shortcut is the same.
Before After
截圖 2024-12-04 晚上10 40 43 截圖 2024-12-04 晚上10 40 24

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dognose24 dognose24 added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 4, 2024
@dognose24 dognose24 requested review from kangzj and a team December 4, 2024 14:52
@dognose24 dognose24 self-assigned this Dec 4, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats_fix_default_7_days_range on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats        +51 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@dognose24 dognose24 merged commit 2285468 into trunk Dec 4, 2024
15 of 16 checks passed
@dognose24 dognose24 deleted the update/stats_fix_default_7_days_range branch December 4, 2024 15:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants