Checkout - fixing additional promo for 2 year Jetpack plans

[grzegorz-cp]

Related to https://github.com/Automattic/jetpack-marketing/issues/1106

Proposed Changes

• Show all discounts for the two year introductory offer, including additional promotions like Black Friday

Why are these changes being made?

• to avoiding showing a price without discount

Testing Instructions

• checkout live branch
• apply this URL - /checkout/jetpack/jetpack_stats_yearly:-q-10000?source=jetpack-plans&checkoutBackUrl=http%3A%2F%2Fjetpack.cloud.localhost%3A3000%2Fpricing%23jetpack_stats_yearly
• verify that the amount on the two year upsell shows an additional discount and the prices match the dropdown (screenshot below)
• repeat the same check for a bundle and verify that the additional discount is not showing up for items with an introductory offer (and the final price matches the dropdown price)

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126274

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126274&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126274&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/1106-2-y-discount on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~19 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +154 B  (+0.0%)      +19 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~19 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal            +154 B  (+0.0%)      +19 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal       +154 B  (+0.0%)      +19 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[robertsreberski]

This looks good, and resolves issue with Stats and other tiered products without introductory offer. Thanks!

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17043716

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @grzegorz-cp for including a screenshot in the description! This is really helpful for our translators.