Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Profiler: Keep insight foldable card open when insight is retrieved #96984

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Dec 2, 2024

Related to #96959

Proposed Changes

  • Expand the Insights foldable cards explicitly when retrieving an insight detail

Before

CleanShot.2024-12-02.at.19.06.36.mp4

After

CleanShot.2024-12-02.at.19.23.17.mp4

Why are these changes being made?

Testing Instructions

  • Navigate to the Speed Test tool and run a test or open an existing report, e.g. /speed-test-tool?hash=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpZCI6NzA3MX0.m3-63iGZmpJOpOfkZ4ww184EoKd8P3UHzTYwv1VLQUo&url=https%3A%2F%2Fwordpress.com%2F&tab=mobile
  • Scroll down to the insight section, and expand an insight, wait for the result to be generated
  • Check the card is kept open
  • Please check there are no unexpected regressions with the foldable cards with regards to their open/close state

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/expand-insight-card on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
site-performance            +11 B  (+0.0%)       +1 B  (+0.0%)
performance-profiler        +11 B  (+0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@epeicher epeicher self-assigned this Dec 2, 2024
Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Roberto! LGTM 👍

@epeicher epeicher merged commit 595b41e into trunk Dec 3, 2024
13 checks passed
@epeicher epeicher deleted the fix/expand-insight-card branch December 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants