Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Redesign on site input step #96983

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Dec 2, 2024

Fixes #96413

Proposed Changes

  • Update the layout and copy for the "Why should you host with us?" section in the site input step.

Before

Screenshot 2024-12-02 at 12 40 11 PM

After

Screenshot 2024-12-02 at 1 53 17 PM

Why are these changes being made?

  • Changes based on site migrations walkthrough p58i-iHv-p2

Testing Instructions

  • Switch to this PR
  • Navigate to /start
  • Go through the flow and select import/migrate at goal selection
  • Note the changes on the site input step

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sixhours sixhours added the [Feature] Site Migration Features related to site migrations to WPcom label Dec 2, 2024
@sixhours sixhours requested review from fditrapani and a team December 2, 2024 17:40
@sixhours sixhours self-assigned this Dec 2, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 2, 2024
@sixhours sixhours added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 2, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/text-on-flow on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fditrapani
Copy link
Contributor

fditrapani commented Dec 2, 2024

Thanks for getting this started @sixhours!

I just posted an updated design + copy based on a more recent walkthrough here: p9Jlb4-fiH-p2

Would it be too much trouble to get the content updated in this PR?

@a8ci18n
Copy link

a8ci18n commented Dec 2, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17041922

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Migrations flow: "Why should you host with us?" section needs tightening
4 participants