Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Add new translations for the remove domain dialog changes #96982

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

DavidRothstein
Copy link
Contributor

This pull request is just here to add the "String Freeze" label to the new translations from #96701 (apparently that label doesn't work when added to pull requests by non-Automatticians).

This should not be merged.

Here are screenshots of what the newly-translated text will look like within the context of the above pull request:

First step:

step-1

Second step:

step-2

@DavidRothstein DavidRothstein added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Dec 2, 2024
@DavidRothstein DavidRothstein self-assigned this Dec 2, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/new-remove-domain-dialog-translations on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~27 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases        +87 B  (+0.0%)      +27 B  (+0.0%)
purchases             +87 B  (+0.0%)      +27 B  (+0.0%)
domains               +87 B  (+0.0%)      +27 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DavidRothstein DavidRothstein added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Dec 2, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 2, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17041926

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @DavidRothstein for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants