Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce axes width to better use space #96975

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Dec 2, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/9966

Proposed Changes

I propose slightly reducing the width of the left and right axes to optimize the space used for the chart.

Why are these changes being made?

There is too much padding on the left side of the chart and we would like to better ruse that space.

The PR reduces both axes width by 10px so it gives more room for the chart itself.

It's still not ideal on the left side for low numbers. It's caused by how the chart library is implemented internally - it uses a fixed width for the axis and then aligns the text to the axis itself.

It looks for short labels as follows now:

Desktop Mobile
Screenshot 2024-12-02 at 16 23 35 Screenshot 2024-12-02 at 16 23 55
Desktop Mobile
Screenshot 2024-12-02 at 16 23 10 Screenshot 2024-12-02 at 16 22 58

Testing Instructions

  1. Open Calypso locally or use a Calypso Live link
  2. Navigate to the /sites page
  3. Locate a Business site with enabled Hosting features
  4. Open the site's card and click the Monitoring tab
  5. Confirm that the Server Performance chart has better y-axis labels spacing

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@wojtekn wojtekn requested a review from a team December 2, 2024 15:36
@wojtekn wojtekn self-assigned this Dec 2, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 2, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/monitoring-line-chart-padding on your sandbox.

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and I did not observe any issues / regressions. 👌🏼🙂

It's still not ideal on the left side for low numbers. It's caused by how the chart library is implemented internally - it uses a fixed width for the axis and then aligns the text to the axis itself.

I run into this case as well when testing, but still think the change is worth it as it adds more space to the chart.

Markup on 2024-12-02 at 17:54:49

@wojtekn wojtekn added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Dec 2, 2024
@wojtekn wojtekn merged commit 2de0217 into trunk Dec 3, 2024
15 of 16 checks passed
@wojtekn wojtekn deleted the update/monitoring-line-chart-padding branch December 3, 2024 09:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groundskeeping Issues handled through Dotcom Groundskeeping rotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants