-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help Center: Open chat images in a new tab #96969
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~32 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Screen.Recording.2024-12-02.at.16.47.18.movThe image is not clickable right away for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@escapemanuele - I'm having the issue Kosta mentioned above. I can't click on the image and it crashes after I send a message.
Thanks, I disabled the click on the image right after sending it, since we don't have a true URL but instead a I'll address the crash that happens! |
d2be373
to
648aeeb
Compare
I've tested the image part and OK - I've seen the recently images sent for HE are for a next PR :) I've been testing quite a lot the new chat and I've not seen any issue (one minor thing is just that the initial language shown for new conversation does not match the WordPress language set) |
Yes, the images you sent in previously conversations are also clickable. It is just that the attachment works with not showing the image from Zendesk, but creating a local URL for the file. We'll work on this to check if it is fixable. But the main motivation for the change is because users cannot open images received by HEs, so I quickly created this :)
Well, this change is for attachments shared between users and HEs :)
If you can, add something to the Cft! pdDR7T-1X1-p2 |
Fixes https://github.com/Automattic/dotcom-forge/issues/10019
TODO: Open images in a new tab
Proposed Changes
Opens the images sent in the chat in a new page.
Testing Instructions