Fix broken 'Add site' link on the list of domains

[wojtekn]

Related to https://github.com/Automattic/dotcom-forge/issues/9785

Proposed Changes

I propose fixing a broken 'Add site' link in the list of domains.

Why are these changes being made?

The table row on the Domains page points to the page that allows managing a domain. The 'Add site' link on the grid should point to a new site flow, similar to the CTA on the domain manage page.

Currently, due to a bug, when users click 'Add site' on the list of domains, the link action is ignored and they are navigated to manage domain form.

I propose to fix the issue by adding an onclick handler to stop the propagation. A similar approach was followed in other places.

Testing Instructions

1. Open Calypso locally or use a Calypso Live link
2. Navigate to the /domains/manage page
3. Locate a domain that is not attached to a site
4. Click the 'Add site' link and confirm it points to a new site flow
5. Navigate back and confirm that the domain row still points to the domain manage page

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-39d622b41aa73a6660e4b7078b2f80a4abc4c3f1

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-39d622b41aa73a6660e4b7078b2f80a4abc4c3f1&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-39d622b41aa73a6660e4b7078b2f80a4abc4c3f1&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-overview        +31 B  (+0.0%)       +1 B  (+0.0%)
hosting              +31 B  (+0.0%)       +1 B  (+0.0%)
domains              +31 B  (+0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[fditrapani]

I tested this and it works! Thanks for the quick fix.