Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Woo rebrand signup page #96963

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Dec 2, 2024

Related to #96946

Proposed Changes

  • Adds woocommerce/rebrand-2-0 feature flag
  • Adds CSS modifications for Woo rebrand 2.0
  • Minor copy change (not under feature flag)

Testing Instructions

  • In your development.json, set woocommerce/rebrand-2-0 to true
  • Run yarn start
  • In an incognito window, go to this URL
  • Observe the changes match with Figma tp2u3Nk9arcpeNMZcylNG4-fi-271_8254

Optional

  • Set the feature flag to false
  • Re-run yarn start
  • In an incognito window, go to this URL
  • Observe the page is not affected by branding changes

After:

image

Figma:

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~84 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +404 B  (+0.0%)      +85 B  (+0.0%)
entry-main          +404 B  (+0.0%)      +85 B  (+0.0%)
entry-login         +404 B  (+0.0%)      +84 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~3 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
jetpack-connect        -11 B  (-0.0%)       -3 B  (-0.0%)
accept-invite          -11 B  (-0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user        -11 B  (-0.0%)       -3 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -1335,7 +1335,7 @@ class SignupForm extends Component {
case this.props.isWoo:
formProps = {
inputPlaceholder: null,
submitButtonLabel: this.props.translate( 'Continue with email' ),
submitButtonLabel: this.props.translate( 'Continue' ),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is expected to be outside of feature flag

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/96946-woo-rebrand-signup-page on your sandbox.

@ilyasfoo ilyasfoo requested review from a team, psealock and moon0326 December 2, 2024 12:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2024
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants