-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Woo rebrand signup page #96963
base: trunk
Are you sure you want to change the base?
Add Woo rebrand signup page #96963
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~84 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~3 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~3 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -1335,7 +1335,7 @@ class SignupForm extends Component { | |||
case this.props.isWoo: | |||
formProps = { | |||
inputPlaceholder: null, | |||
submitButtonLabel: this.props.translate( 'Continue with email' ), | |||
submitButtonLabel: this.props.translate( 'Continue' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is expected to be outside of feature flag
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well 👍 🚀
Related to #96946
Proposed Changes
woocommerce/rebrand-2-0
feature flagTesting Instructions
development.json
, setwoocommerce/rebrand-2-0
totrue
yarn start
Optional
yarn start
After:
Figma:
Pre-merge Checklist