-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix back link in user security page #96952
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~50 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, currently the existing Back to Hosting Configuration
text is also inaccurate as it has been replaced by Server Settings
.
Back to Advanced Tools
also sounds a bit weird because it's the tab name, not the subtab. I'd propose to just simply use Back
for all scenarios. What do you think? cc: @taipeicoder
Yes, let's just use |
Makes sense. Updated the button text to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended 👍
Fixes: https://github.com/Automattic/dotcom-forge/issues/10004
Proposed Changes
Testing Instructions
/sites/tools/sftp-ssh/:site
Add an SSH Key
Pre-merge Checklist