Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back link in user security page #96952

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

madhusudhand
Copy link
Member

Fixes: https://github.com/Automattic/dotcom-forge/issues/10004

Proposed Changes

  • Fixes back link in user security page when visited from Advanced Tools (UHM enabled)
  • Updates the source param of security page
  • Updates back link text based on the source url
image

Testing Instructions

  • Visit /sites/tools/sftp-ssh/:site
  • Click on Add an SSH Key
  • It should take you to user security page.
  • Back link and text should be updated pointing to Advanced Tools page, and clicking on which should land user in the previous page.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@madhusudhand madhusudhand requested a review from a team December 2, 2024 07:34
@madhusudhand madhusudhand self-assigned this Dec 2, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 2, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/ssh-key-back-link on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~50 bytes added 📈 [gzipped])

name          parsed_size           gzip_size
staging-site       +108 B  (+0.0%)      +31 B  (+0.0%)
site-tools         +108 B  (+0.0%)      +25 B  (+0.0%)
hosting            +108 B  (+0.0%)      +31 B  (+0.0%)
security            +23 B  (+0.0%)       -6 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, currently the existing Back to Hosting Configuration text is also inaccurate as it has been replaced by Server Settings.

Back to Advanced Tools also sounds a bit weird because it's the tab name, not the subtab. I'd propose to just simply use Back for all scenarios. What do you think? cc: @taipeicoder

@taipeicoder
Copy link
Contributor

Yes, let's just use Back.

@madhusudhand
Copy link
Member Author

Back to Advanced Tools also sounds a bit weird because it's the tab name, not the subtab

Makes sense. Updated the button text to Back for all scenarios. 82b5a86

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

@madhusudhand madhusudhand merged commit 0afac8f into trunk Dec 3, 2024
11 checks passed
@madhusudhand madhusudhand deleted the fix/ssh-key-back-link branch December 3, 2024 08:38
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants