Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: Make the back button point to the previous page #89075

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Apr 1, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/6306

Proposed Changes

  • Make the back button on the Profile page point to the previous path instead of /sites

Testing Instructions

  • Go to the Profile page, /me
  • Click the < Back button on the sidebar
  • Make sure you go to the All Sites page
  • Go to any page on your site, e.g.: /settings/general/<your_site>
  • Go to the Profile page again
  • Make sure you go back to the previous page
  • Go to Reader page
  • Click the < All sites button on the sidebar
  • Make sure you go to the All Sites page

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 requested a review from a team as a code owner April 1, 2024 11:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 1, 2024
@arthur791004 arthur791004 self-assigned this Apr 1, 2024
@arthur791004 arthur791004 requested review from a team April 1, 2024 11:11
@matticbot
Copy link
Contributor

matticbot commented Apr 1, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~176 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
sites-dashboard                         +451 B  (+0.1%)     +176 B  (+0.1%)
woocommerce-installation                +255 B  (+0.1%)      +87 B  (+0.1%)
woocommerce                             +255 B  (+0.1%)      +87 B  (+0.1%)
themes                                  +255 B  (+0.0%)      +87 B  (+0.0%)
theme                                   +255 B  (+0.0%)      +87 B  (+0.0%)
subscribers                             +255 B  (+0.0%)      +87 B  (+0.0%)
stats                                   +255 B  (+0.0%)      +87 B  (+0.0%)
site-purchases                          +255 B  (+0.0%)      +87 B  (+0.0%)
site-monitoring                         +255 B  (+0.1%)      +87 B  (+0.1%)
site-blocks                             +255 B  (+0.0%)      +87 B  (+0.0%)
settings-writing                        +255 B  (+0.0%)      +87 B  (+0.0%)
settings-security                       +255 B  (+0.1%)      +87 B  (+0.1%)
settings-reading                        +255 B  (+0.1%)      +87 B  (+0.1%)
settings-podcast                        +255 B  (+0.0%)      +87 B  (+0.1%)
settings-performance                    +255 B  (+0.0%)      +87 B  (+0.1%)
settings-newsletter                     +255 B  (+0.1%)      +87 B  (+0.1%)
settings-jetpack                        +255 B  (+0.0%)      +87 B  (+0.1%)
settings-discussion                     +255 B  (+0.1%)      +87 B  (+0.1%)
settings                                +255 B  (+0.0%)      +87 B  (+0.0%)
security                                +255 B  (+0.0%)      +87 B  (+0.0%)
scan                                    +255 B  (+0.0%)      +87 B  (+0.0%)
purchases                               +255 B  (+0.0%)      +87 B  (+0.0%)
promote-post-i2                         +255 B  (+0.1%)      +87 B  (+0.1%)
privacy                                 +255 B  (+0.0%)      +87 B  (+0.0%)
preview                                 +255 B  (+0.1%)      +87 B  (+0.1%)
posts-custom                            +255 B  (+0.0%)      +87 B  (+0.0%)
posts                                   +255 B  (+0.0%)      +87 B  (+0.0%)
plugins                                 +255 B  (+0.0%)      +87 B  (+0.0%)
plans                                   +255 B  (+0.0%)      +87 B  (+0.0%)
people                                  +255 B  (+0.0%)      +87 B  (+0.0%)
pages                                   +255 B  (+0.0%)      +87 B  (+0.1%)
notification-settings                   +255 B  (+0.0%)      +87 B  (+0.0%)
migrate                                 +255 B  (+0.1%)      +87 B  (+0.1%)
media                                   +255 B  (+0.0%)      +87 B  (+0.0%)
me                                      +255 B  (+0.0%)      +87 B  (+0.0%)
marketplace                             +255 B  (+0.0%)      +87 B  (+0.0%)
marketing                               +255 B  (+0.0%)      +87 B  (+0.0%)
jetpack-social                          +255 B  (+0.1%)      +87 B  (+0.1%)
jetpack-search                          +255 B  (+0.0%)      +87 B  (+0.1%)
jetpack-connect                         +255 B  (+0.0%)      +87 B  (+0.0%)
jetpack-cloud-settings                  +255 B  (+0.0%)      +87 B  (+0.1%)
jetpack-cloud-pricing                   +255 B  (+0.0%)      +87 B  (+0.0%)
jetpack-cloud-plugin-management         +255 B  (+0.0%)      +87 B  (+0.0%)
jetpack-cloud-overview                  +255 B  (+0.1%)      +87 B  (+0.1%)
jetpack-cloud-features-comparison       +255 B  (+0.0%)      +87 B  (+0.0%)
jetpack-cloud                           +255 B  (+0.1%)      +87 B  (+0.1%)
import                                  +255 B  (+0.1%)      +87 B  (+0.1%)
hosting                                 +255 B  (+0.0%)      +87 B  (+0.0%)
home                                    +255 B  (+0.0%)      +87 B  (+0.0%)
help                                    +255 B  (+0.0%)      +87 B  (+0.0%)
gutenberg-editor                        +255 B  (+0.0%)      +87 B  (+0.0%)
google-my-business                      +255 B  (+0.0%)      +87 B  (+0.1%)
github-deployments                      +255 B  (+0.0%)      +87 B  (+0.0%)
export                                  +255 B  (+0.1%)      +87 B  (+0.1%)
email                                   +255 B  (+0.0%)      +87 B  (+0.0%)
earn                                    +255 B  (+0.0%)      +87 B  (+0.0%)
domains                                 +255 B  (+0.0%)      +87 B  (+0.0%)
developer                               +255 B  (+0.0%)      +87 B  (+0.0%)
customize                               +255 B  (+0.1%)      +87 B  (+0.1%)
concierge                               +255 B  (+0.0%)      +87 B  (+0.1%)
comments                                +255 B  (+0.0%)      +87 B  (+0.0%)
checkout                                +255 B  (+0.0%)      +87 B  (+0.0%)
backup                                  +255 B  (+0.0%)      +87 B  (+0.0%)
add-ons                                 +255 B  (+0.1%)      +87 B  (+0.1%)
activity                                +255 B  (+0.0%)      +87 B  (+0.0%)
account-close                           +255 B  (+0.0%)      +87 B  (+0.0%)
account                                 +255 B  (+0.0%)      +87 B  (+0.0%)
import-hosted-site-flow                 +196 B  (+0.0%)      +89 B  (+0.0%)
import-flow                             +196 B  (+0.0%)      +89 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~95 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-calypso-reader-sidebar       +277 B  (+0.1%)      +95 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Apr 1, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • editing-toolkit
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/me-back-link on your sandbox.

Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me. I tested on classic view, early access, and Simple.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@DustyReagan DustyReagan merged commit ea21d07 into trunk Apr 2, 2024
12 of 16 checks passed
@DustyReagan DustyReagan deleted the fix/me-back-link branch April 2, 2024 21:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants