-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the stats tab in the preview pane to match design specs #89072
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~23 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -11,7 +11,7 @@ type Props = { | |||
export function JetpackStatsPreview( { site, trackEvent }: Props ) { | |||
return ( | |||
<> | |||
<SitePreviewPaneContent> | |||
<SitePreviewPaneContent className="site-preview-pane__stats-content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/109
Proposed Changes
Conversation around the stats section in Figma here, beyond what is included in the designs themselves: 1UpoqS1KkCtLXVX68TbMSM-fi-6144_260191#747621639
Testing Instructions
For the below testing steps, make sure to run
yarn start-a8c-for-agencies
locally and then visithttp://agencies.localhost:3000/sites
.Pre-merge Checklist