Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Add min-height to SubmitFooterWrapper #88977

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jjchrisdiehl
Copy link
Contributor

The SubmitFooterWrapper tends to get obscured by the Zendesk support widget on mobile width devices. The first attempt to resolve this was done in #88819 but it didn't quite fix the issue entirely. Instead, it handled the spacing requirements of the x axis but we still needed to manage spacing requirements on the y axis.

Before After
image image

This PR adds a min-height that prevents the ZD button from overlapping the payment button. Using min height also allows the money back guarantee text to grow without breaking the layout and provides a little extra white space to the bottom of the page which makes it feel less congested.

Related to #88819

Testing Instructions

  • Go to checkout and ensure the submit wrapper footer looks correct at desktop size
  • Begin to shrink the width of the browser down to 425px (or lower!) and ensure the ZD button doesn't overlap the payment button
  • The text should also adjust if the button is about to clip over it
  • Go to Jetpack/Akismet checkouts and do the same (with Jetpack, they use a separate footer but it shares the same SubmitFooterWrapper component, there shouldn't be a noticeable difference here)

@jjchrisdiehl jjchrisdiehl self-assigned this Mar 27, 2024
@jjchrisdiehl jjchrisdiehl requested a review from a team as a code owner March 27, 2024 20:53
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 27, 2024
@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~10 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
site-purchases                      +16 B  (+0.0%)      +10 B  (+0.0%)
purchases                           +16 B  (+0.0%)      +10 B  (+0.0%)
jetpack-cloud-partner-portal        +16 B  (+0.0%)      +10 B  (+0.0%)
checkout                            +16 B  (+0.0%)      +10 B  (+0.0%)
a8c-for-agencies-purchases          +16 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +16 B  (+0.0%)      +10 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +16 B  (+0.0%)      +10 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jjchrisdiehl jjchrisdiehl force-pushed the refactor/checkout-form-submit branch from b0d488f to c35b6a3 Compare March 28, 2024 23:09
Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjchrisdiehl jjchrisdiehl force-pushed the refactor/checkout-form-submit branch from c35b6a3 to 8e83f01 Compare April 1, 2024 23:36
@jjchrisdiehl jjchrisdiehl merged commit f134082 into trunk Apr 2, 2024
11 checks passed
@jjchrisdiehl jjchrisdiehl deleted the refactor/checkout-form-submit branch April 2, 2024 20:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants