-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecommerce Segmentation Survey: Create Survey main component and routing provider #88922
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
eba5699
to
0b2b198
Compare
client/components/paginated-survey/components/question-step.tsx
Outdated
Show resolved
Hide resolved
client/components/paginated-survey/components/question-step.tsx
Outdated
Show resolved
Hide resolved
client/components/paginated-survey/components/question-step.tsx
Outdated
Show resolved
Hide resolved
<QuestionStep | ||
previousPage={ previousPage } | ||
nextPage={ nextPage } | ||
skip={ nextPage } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to know if the questions have been skipped, but this is more on the storing the answers part (cc @JuanLucha).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to know, but I'm not sure if we are going to find out by comparing the questions with their answers instead of specifically storing a "skipped" status. Something to think about, indeed.
...epper/declarative-flow/internals/steps-repository/ecommerce-segmentation-survey/provider.tsx
Show resolved
Hide resolved
|
||
export const questions: Question[] = [ | ||
{ | ||
headerText: translate( 'What is your favorite color?' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a mock, but I think the questions should be moved to server-side (cc @JuanLucha).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, something to think about. I'm doing a test for that at the moment.
52284b5
to
cfe3816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice with the changes implemented 👌
Closes #88920
Proposed Changes
ecommerce-segmentation-survey
.TODOs
Testing Instructions
git revert cfe3816
Pre-merge Checklist