Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin update manager: Make eligibility checks more async #88452

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

TimBroddin
Copy link
Contributor

@TimBroddin TimBroddin commented Mar 13, 2024

Closes #88416

Proposed Changes

  • Extends the useIsEligibleForFeature hook with the logic to calculate if the site is eligble
  • Gets rid of the spinner on index.tsx
  • Only show the eligibility notice after everything is loaded
Atomic Creator non-atomic Explorer
CleanShot 2024-03-13 at 10 55 28@2x CleanShot 2024-03-13 at 10 55 00@2x CleanShot 2024-03-13 at 10 55 38@2x

Testing Instructions

  1. Apply the PR
  2. Check for regressions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~16 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                               +128 B  (+0.0%)      +16 B  (+0.0%)
jetpack-cloud-plugin-management       +128 B  (+0.0%)      +16 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@TimBroddin TimBroddin marked this pull request as ready for review March 13, 2024 09:57
@TimBroddin TimBroddin requested a review from a team March 13, 2024 09:57
@TimBroddin TimBroddin self-assigned this Mar 13, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 13, 2024
@TimBroddin TimBroddin changed the title Make eligibility checks more async Plugin update manager: Make eligibility checks more async Mar 13, 2024
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a good job of cleaning up the entry component logic.
I've tested with the different site plans, and it seems there are no regressions.

👍

@TimBroddin TimBroddin merged commit ba1e802 into trunk Mar 13, 2024
16 checks passed
@TimBroddin TimBroddin deleted the update/plugin-manager-eligible-check branch March 13, 2024 10:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 13, 2024
@ouikhuan
Copy link
Contributor

Tested with:

  • Simple site -> upgrade to Creator plan -> transfer to Atomic
  • Atomic
  • Jetpack site
  • Sites with Explorer plan

All works as expected, nice job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants