Plugins update manager: Add translation #88300

bogiii · 2024-03-07T14:56:21Z

Related to #87896

Proposed Changes

Module translation

Testing Instructions

Go to /plugins/scheduled-updates/{ATOMIC_SITE}
Check if everything works fine as before

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

matticbot · 2024-03-07T14:57:18Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-100367

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-100367&env=jetpack

matticbot · 2024-03-07T15:06:54Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~90 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                               +399 B  (+0.0%)      +90 B  (+0.0%)
jetpack-cloud-plugin-management       +399 B  (+0.0%)      +90 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

obenland

@JanaMW27 When you get a chance, could you review my copy suggestions?

client/blocks/plugins-update-manager/index.tsx

obenland · 2024-03-07T17:13:58Z

client/blocks/plugins-update-manager/index.tsx

-					title="Plugin updates manager"
-					subtitle="Effortlessly schedule plugin auto-updates with built-in rollback logic."
+					title={ translate( 'Plugin updates manager' ) }
+					subtitle={ translate( 'Schedule automatic plugin updates' ) }


Set up automated schedules so plugins update when you want them to.

This copy was reviewed and approved by the copywriting team. Why it needs to be changed?

I think there's an opportunity to be more descriptive in some of these places

I also think that there is a space to be more specific, but I would leave it for the next PRs since I'm going to deploy this one.

@bogiii Could I ask you to hold off if we plan to make changes to translation strings? We should avoid sending strings to translation (and pay for those translations) when there's a good chance they'll get changed again

Ouch. I've deployed it.
I wanted to avoid resolving future conflicts and deployed it.

client/blocks/plugins-update-manager/schedule-form.helper.ts

client/blocks/plugins-update-manager/schedule-list.tsx

obenland · 2024-03-07T17:23:28Z

client/blocks/plugins-update-manager/index.tsx

@@ -68,7 +70,7 @@ export const PluginsUpdateManager = ( props: Props ) => {
 							onClick={ onCreateNewSchedule }
 							disabled={ ! canCreateSchedules }
 						>
-							Create a new schedule
+							{ translate( 'Set up a new schedule' ) }


Can we simplify this to "Create new schedule"? Or "Add new schedule" to align it with "Add new post"?

It used to be "Create a new schedule", but the copy was reviewed and changed to be "Set up a new schedule".

@JanaMW27, what do you think?

Both copies sound good to me. Maybe "set up" is more aligned with the user action? I dunno, both work for me.

client/blocks/plugins-update-manager/schedule-create.tsx

zaerl

LGTM. Great work. 🚢

This reverts commit 6c52385.

…8373)" This reverts commit f070f10.

@provenself

* Revert "Revert "Plugins update manager: Add translation (#88300)" (#88373)" This reverts commit f070f10. * Apply first batch of suggestions from code review Props @provenself * Update subtitle wording * Add trailing period. * Remove unnecessary info text. This is now covered in empty state. * Fix curly quote --------- Co-authored-by: Konstantin Obenland <[email protected]>

* Translate PluginsUpdateManager component * Translate ScheduleCreate component * Translate ScheduleEdit component * Update copy of PluginsUpdateManager * Translate ScheduleList component * Translate ScheduleListEmpty component * Translate ScheduleListTable component * Translate ScheduleListCards component * Translate ScheduleForm component * Translate ScheduleForm constants and helpers * Remove unused validateName function * Reuse the same translation * Update copy

This reverts commit 6c52385.

@provenself

* Revert "Revert "Plugins update manager: Add translation (#88300)" (#88373)" This reverts commit f070f10. * Apply first batch of suggestions from code review Props @provenself * Update subtitle wording * Add trailing period. * Remove unnecessary info text. This is now covered in empty state. * Fix curly quote --------- Co-authored-by: Konstantin Obenland <[email protected]>

bogiii requested a review from a team March 7, 2024 16:59

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 7, 2024

bogiii self-assigned this Mar 7, 2024

bogiii marked this pull request as ready for review March 7, 2024 16:59

obenland requested changes Mar 7, 2024

View reviewed changes

zaerl self-requested a review March 8, 2024 10:22

bogiii mentioned this pull request Mar 8, 2024

FE: Handle generic error message #88334

Closed

bogiii force-pushed the add/plugin-updates-manager-8 branch from f692c06 to d11b19c Compare March 8, 2024 10:41

zaerl approved these changes Mar 8, 2024

View reviewed changes

bogiii added 13 commits March 11, 2024 14:07

Translate PluginsUpdateManager component

95a6d59

Translate ScheduleCreate component

6cbfde8

Translate ScheduleEdit component

5d805f7

Update copy of PluginsUpdateManager

a2f6c64

Translate ScheduleList component

20cb98c

Translate ScheduleListEmpty component

088d8e4

Translate ScheduleListTable component

8b6c5b1

Translate ScheduleListCards component

be90b00

Translate ScheduleForm component

ce55e77

Translate ScheduleForm constants and helpers

e7a27a6

Remove unused validateName function

f1a0b80

Reuse the same translation

cad3976

Update copy

4d8f6f5

bogiii force-pushed the add/plugin-updates-manager-8 branch from c3c562d to 4d8f6f5 Compare March 11, 2024 13:10

bogiii merged commit 6c52385 into trunk Mar 11, 2024
11 checks passed

bogiii deleted the add/plugin-updates-manager-8 branch March 11, 2024 13:23

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 11, 2024

bogiii added a commit that referenced this pull request Mar 11, 2024

Revert "Plugins update manager: Add translation (#88300)"

a663348

This reverts commit 6c52385.

bogiii mentioned this pull request Mar 11, 2024

Revert "Plugins update manager: Add translation (#88300)" #88373

Merged

7 tasks

bogiii added a commit that referenced this pull request Mar 11, 2024

Revert "Plugins update manager: Add translation (#88300)" (#88373)

f070f10

This reverts commit 6c52385.

bogiii added a commit that referenced this pull request Mar 11, 2024

Revert "Revert "Plugins update manager: Add translation (#88300)" (#8…

a9e4d2e

…8373)" This reverts commit f070f10.

bogiii mentioned this pull request Mar 11, 2024

Plugins update manager: Add translation #88375

Merged

7 tasks

obenland pushed a commit that referenced this pull request Mar 12, 2024

Revert "Revert "Plugins update manager: Add translation (#88300)" (#8…

e3d5f88

…8373)" This reverts commit f070f10.

bogiii added a commit that referenced this pull request Mar 13, 2024

Revert "Revert "Plugins update manager: Add translation (#88300)" (#8…

69db8bf

…8373)" This reverts commit f070f10.

billrobbins pushed a commit that referenced this pull request Mar 20, 2024

Revert "Plugins update manager: Add translation (#88300)" (#88373)

2ee8ab1

This reverts commit 6c52385.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plugins update manager: Add translation #88300

Plugins update manager: Add translation #88300

bogiii commented Mar 7, 2024 •

edited

Loading

matticbot commented Mar 7, 2024 •

edited

Loading

matticbot commented Mar 7, 2024 •

edited

Loading

obenland left a comment

obenland Mar 7, 2024

JanaMW27 Mar 8, 2024

obenland Mar 8, 2024

bogiii Mar 11, 2024

obenland Mar 11, 2024

bogiii Mar 11, 2024

obenland Mar 7, 2024

bogiii Mar 8, 2024

JanaMW27 Mar 8, 2024

zaerl left a comment

Plugins update manager: Add translation #88300

Plugins update manager: Add translation #88300

Conversation

bogiii commented Mar 7, 2024 • edited Loading

Proposed Changes

Testing Instructions

Pre-merge Checklist

matticbot commented Mar 7, 2024 • edited Loading

matticbot commented Mar 7, 2024 • edited Loading

obenland left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zaerl left a comment

Choose a reason for hiding this comment

bogiii commented Mar 7, 2024 •

edited

Loading

matticbot commented Mar 7, 2024 •

edited

Loading

matticbot commented Mar 7, 2024 •

edited

Loading